Skip to content

File not closed causing test fail on windows #10368

@ianwoolf

Description

@ianwoolf

I use testing.TempDir instead of ioutil.TempDir in promql.TestQueryConcurrency. The test pass in mac and linux, but always fails on windows. As mentioned in the comment in the link below, the file is still used by query log, causing the deletion of the directory to fail.

#10321 (comment)

I don't know why the test only fails on windows, but i feel like ActiveQueryTracker needs a close method to close the file in using.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions