Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus/prometheus
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5354e87
Choose a base ref
...
head repository: prometheus/prometheus
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e6cfa72
Choose a head ref
  • 14 commits
  • 18 files changed
  • 5 contributors

Commits on Aug 8, 2024

  1. Ignore stale histograms for counter reset detection

    The histogram stats decoder keeps track of the last seen histogram sample
    in order to properly detect counter resets. We are seeing an issue where
    a histogram with UnknownResetHint gets treated as a counter reset when it follows
    a stale histogram sample.
    
    I believe that this is incorrect since stale samples should be completely ignored
    in PromQL. As a result, they should not be stored in the histogram stats iterator
    and the counter reset detection needs to be done against the last non-stale sample.
    
    Signed-off-by: Filip Petkovski <[email protected]>
    fpetkovski authored and krajorama committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    6100e75 View commit details
    Browse the repository at this point in the history
  2. Add more test cases

    Signed-off-by: Filip Petkovski <[email protected]>
    fpetkovski authored and krajorama committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    02d9d87 View commit details
    Browse the repository at this point in the history
  3. Use CopyTo when resetting histogram in stats iterator

    The histogram stats iterator does not fully clear the histogram object
    and is not resilient to new fields being added to the histogram type.
    
    To resolve the issue, the commit uses the CopyTo methods which should
    be future proof to new fields being added.
    
    Signed-off-by: Filip Petkovski <[email protected]>
    fpetkovski authored and krajorama committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8f9751b View commit details
    Browse the repository at this point in the history
  4. Fix histogram pool poisoning bu chunkenc.Iterator

    chunkenc.Iterator.AtFloatHistogram may do a shallow copy if
    it receives nil as input pointer. This can in turn share the
    span slice with multiple histograms in the matrixSelectorHPool,
    leading to unexpected errors.
    
    Signed-off-by: György Krajcsovits <[email protected]>
    krajorama committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    909785b View commit details
    Browse the repository at this point in the history
  5. Add unit test

    Signed-off-by: György Krajcsovits <[email protected]>
    krajorama committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1fb0ff7 View commit details
    Browse the repository at this point in the history
  6. Update promql/engine.go

    Signed-off-by: George Krajcsovits <[email protected]>
    krajorama committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    1d7fe4b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge pull request #14623 from prometheus/backport-pr14514-to-2.54

    Ignore stale histograms for counter reset detection
    bboreham authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    03d5c63 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #14624 from prometheus/backport-pr14538-to-2.54

    Use CopyTo when resetting histogram in stats iterator
    bboreham authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    26977b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. [BUGFIX] Scraping: allow multiple samples on same series (#14685)

    So long as they specify timestamps. We don't check that the timestamps
    are different.
    
    Extend test, and use client_golang/prometheus/testutil to simplify metric check.
    
    Signed-off-by: Bryan Boreham <[email protected]>
    bboreham authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    144470c View commit details
    Browse the repository at this point in the history
  2. fix the issue of failing to match the first network when the containe…

    …r is reconnected to a new network
    
    Signed-off-by: [email protected] <[email protected]>
    DrAuYueng committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    89dee48 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #14654 from DrAuYueng/docker-network-mode-match

    [BUGFIX] Docker SD: fix the issue of failing to match the first network when the container is reconnected to a new network
    bboreham authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2eb24bf View commit details
    Browse the repository at this point in the history
  4. Merge pull request #14625 from prometheus/backport-pr14605-to-2.54

    Fix histogram pool poisoning bug chunkenc.Iterator
    bboreham authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    414d529 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Cut release 2.54.1

    Signed-off-by: Bryan Boreham <[email protected]>
    bboreham committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    da28f88 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #14739 from prometheus/prep-2.54.1

    Cut release 2.54.1
    bboreham authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    e6cfa72 View commit details
    Browse the repository at this point in the history
Loading