nvme: add namespace parameters#3360
Merged
SuperQ merged 18 commits intoprometheus:masterfrom Mar 4, 2026
Merged
Conversation
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Contributor
Author
Member
|
Could you try to add tests for the new metrics? |
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Contributor
Author
|
I have updated the fixtures and the output.txt. |
Member
|
Seems reasonable but parsing should go into the prometheus/procfs module |
Contributor
Author
|
Ok 👍 prometheus/procfs#765 please approve it |
Contributor
Author
|
After they are merged, i can apply this patch and update the go.mod file with the new release tag |
Contributor
Author
|
hi @discordianfish It's been a while. |
discordianfish
approved these changes
Jan 16, 2026
discordianfish
requested changes
Jan 16, 2026
Member
discordianfish
left a comment
discordianfish
left a comment
There was a problem hiding this comment.
Oops, sorry - right still needs prometheus/procfs#765 first
SuperQ
approved these changes
Feb 28, 2026
refactor: use updated library to collect NVMe namespace metrics directly from structured data instead of manual sysfs parsing. Signed-off-by: Shashwat Hiregoudar <[email protected]>
go mod tidy Signed-off-by: Shashwat Hiregoudar <[email protected]>
Contributor
Author
|
@SuperQ can you please create a new release in procfs, |
Member
|
I cut a new procfs version a few hours ago. |
Updated the version of github.com/prometheus/procfs to v0.20.1. Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
SuperQ
requested changes
Mar 2, 2026
ShashwatHiregoudar
force-pushed
the
master
branch
3 times, most recently
from
9aa8d26 to
2a166b3
Compare
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Signed-off-by: Shashwat Hiregoudar <[email protected]>
Contributor
Author
|
@SuperQ |
SuperQ
added a commit
that referenced
this pull request
Apr 4, 2026
* [CHANGE] Adds distroless container image. #3592 * [FEATURE] infiniband: Add `hw_counters` metrics #2827 * [FEATURE] kernel_hung: Add collector for kernel hung tasks #3470 * [FEATURE] mixin: Add "All" option to cluster variable in dashboards #3509 * [FEATURE] netlink: Add node_network_altnames_info metric #3541 * [FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon #3547 * [FEATURE] bcachefs: Add new collector for bcachefs #3523 * [ENHANCEMENT] mixin: Make devices in network graphs configurable #3525 * [ENHANCEMENT] nvme: Add namespace parameters #3360 * [BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric #3340 * [BUGFIX] mountstats: Fix multiple transports statistics labeling #3358 * [BUGFIX] diskstats: Fix panic when using device-include flag only #3603 Signed-off-by: Ben Kochie <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Apr 4, 2026
* [CHANGE] Adds distroless container image. #3592 * [FEATURE] infiniband: Add `hw_counters` metrics #2827 * [FEATURE] kernel_hung: Add collector for kernel hung tasks #3470 * [FEATURE] mixin: Add "All" option to cluster variable in dashboards #3509 * [FEATURE] netlink: Add node_network_altnames_info metric #3541 * [FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon #3547 * [FEATURE] bcachefs: Add new collector for bcachefs #3523 * [ENHANCEMENT] mixin: Make devices in network graphs configurable #3525 * [ENHANCEMENT] nvme: Add namespace parameters #3360 * [BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric #3340 * [BUGFIX] mountstats: Fix multiple transports statistics labeling #3358 * [BUGFIX] diskstats: Fix panic when using device-include flag only #3603 Signed-off-by: Ben Kochie <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Apr 4, 2026
* [CHANGE] Adds distroless container image. #3592 * [FEATURE] infiniband: Add `hw_counters` metrics #2827 * [FEATURE] kernel_hung: Add collector for kernel hung tasks #3470 * [FEATURE] mixin: Add "All" option to cluster variable in dashboards #3509 * [FEATURE] netlink: Add node_network_altnames_info metric #3541 * [FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon #3547 * [FEATURE] bcachefs: Add new collector for bcachefs #3523 * [ENHANCEMENT] mixin: Make devices in network graphs configurable #3525 * [ENHANCEMENT] nvme: Add namespace parameters #3360 * [BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric #3340 * [BUGFIX] mountstats: Fix multiple transports statistics labeling #3358 * [BUGFIX] diskstats: Fix panic when using device-include flag only #3603 Signed-off-by: Ben Kochie <[email protected]>
renovate Bot
added a commit
to sdwilsh/sOS
that referenced
this pull request
Apr 7, 2026
….11.1 ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
renovate Bot
added a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Apr 8, 2026
….11.1 ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
sdwilsh
pushed a commit
to sdwilsh/ansible-playbooks
that referenced
this pull request
Apr 8, 2026
….11.1 ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
renovate Bot
added a commit
to sdwilsh/sOS
that referenced
this pull request
Apr 10, 2026
….11.1 ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
renovate Bot
added a commit
to sdwilsh/sOS
that referenced
this pull request
Apr 17, 2026
….11.1 ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
1 task
renovate Bot
added a commit
to sdwilsh/sOS
that referenced
this pull request
Apr 24, 2026
….11.1 ##### [\`v1.11.1\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.1) - \[BUGFIX] Fix kernel\_hung for no data [#3613](prometheus/node_exporter#3613) --- ##### [\`v1.11.0\`](https://github.com/prometheus/node_exporter/releases/tag/v1.11.0) - \[CHANGE] Adds distroless container image. [#3592](prometheus/node_exporter#3592) - \[FEATURE] infiniband: Add `hw_counters` metrics [#2827](prometheus/node_exporter#2827) - \[FEATURE] kernel\_hung: Add collector for kernel hung tasks [#3470](prometheus/node_exporter#3470) - \[FEATURE] mixin: Add "All" option to cluster variable in dashboards [#3509](prometheus/node_exporter#3509) - \[FEATURE] netlink: Add node\_network\_altnames\_info metric [#3541](prometheus/node_exporter#3541) - \[FEATURE] thermal: Add support for CPU temperature metrics on Apple Silicon [#3547](prometheus/node_exporter#3547) - \[FEATURE] bcachefs: Add new collector for bcachefs [#3523](prometheus/node_exporter#3523) - \[ENHANCEMENT] mixin: Make devices in network graphs configurable [#3525](prometheus/node_exporter#3525) - \[ENHANCEMENT] nvme: Add namespace parameters [#3360](prometheus/node_exporter#3360) - \[BUGFIX] netdev: Respect deviceFilter for `node_network_address_info` metric [#3340](prometheus/node_exporter#3340) - \[BUGFIX] mountstats: Fix multiple transports statistics labeling [#3358](prometheus/node_exporter#3358) - \[BUGFIX] diskstats: Fix panic when using device-include flag only [#3603](prometheus/node_exporter#3603)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement of the NVMe collector in node-exporter, to include the below-mentioned NVMe namespace-specific parameters NUSE
NCAP
NSZE
LBA Size
ANA State