Introduce Collector for Power Supply Class by shaardie · Pull Request #1280 · prometheus/node_exporter

shaardie · 2019-03-09T17:23:47Z

Use the powerSupplyClass from procfs and show metrics about the power supplies from /sys/class/power_supply as wished in issue #676.

These changes are based in the commit 6ed1f7e in procfs and therefore the depedency is updated.

collector/powersupplyclass.go

collector/fixtures/e2e-output.txt

discordianfish

Thanks for the PR! See comments.

shaardie · 2019-03-22T14:42:13Z

Unfortunately I found a bug in the prometheus/procfs, see prometheus/procfs#145 which has to be fixed first. I already created a Pull Request prometheus/procfs#146

shaardie · 2019-04-04T07:34:44Z

Jeah! My procfs fix was merged, but unfortunately I get a compiling error against the latest procfs version, see #1307. That has to be fixed first...

pgier · 2019-07-09T20:56:20Z

@shaardie The procfs module should be good now, can you rebase your changes?

discordianfish · 2019-07-29T13:54:05Z

@shaardie Sorry for the delay! Are you still interested in updating this PR?

shaardie · 2019-07-30T11:17:43Z

Yes, I already took a small look into this, but it seems like I have to change some more files to make it work again. I will do this as soon as I have time for it. Thanks for applying the changes in procfs, btw.

shaardie · 2019-08-02T17:08:49Z

I have updated the Pull Request. Unfortunately One automatic check failed, but I can not see what this failure is about.

SuperQ · 2019-08-02T17:20:32Z

There is a second e2e test for PowerPC that probably needs updating.

shaardie · 2019-08-02T17:23:48Z

Too bad. I have no access to one. Maybe someone can help with this.

SuperQ · 2019-08-04T11:24:34Z

You don't need access to one, it's just a matter of copy-n-paste the changes so the test will pass.

--- collector/fixtures/e2e-64k-page-output.txt  2019-08-02 12:47:08.000000000 -0400
+++ /tmp/node_exporter_e2e_test.0chWLl/e2e-output.txt   2019-08-02 13:01:42.041089380 -0400
@@ -2382,6 +2382,40 @@
 # HELP node_nfsd_server_threads Total number of NFSd kernel threads that are running.
 # TYPE node_nfsd_server_threads gauge
 node_nfsd_server_threads 8
+# HELP node_power_supply_capacity capacity value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_capacity gauge
+node_power_supply_capacity{power_supply="BAT0"} 81
+# HELP node_power_supply_cyclecount cyclecount value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_cyclecount gauge
+node_power_supply_cyclecount{power_supply="BAT0"} 0
+# HELP node_power_supply_energy_full energy_full value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_energy_full gauge
+node_power_supply_energy_full{power_supply="BAT0"} 4.507e+07
+# HELP node_power_supply_energy_full_design energy_full_design value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_energy_full_design gauge
+node_power_supply_energy_full_design{power_supply="BAT0"} 4.752e+07
+# HELP node_power_supply_energy_now energy_now value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_energy_now gauge
+node_power_supply_energy_now{power_supply="BAT0"} 3.658e+07
+# HELP node_power_supply_info info of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_info gauge
+node_power_supply_info{power_supply="AC",type="Mains"} 1
+node_power_supply_info{capacity_level="Normal",manufacturer="LGC",model_name="LNV-45N1",power_supply="BAT0",serial_number="38109",status="Discharging",technology="Li-ion",type="Battery"} 1
+# HELP node_power_supply_online online value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_online gauge
+node_power_supply_online{power_supply="AC"} 0
+# HELP node_power_supply_power_now power_now value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_power_now gauge
+node_power_supply_power_now{power_supply="BAT0"} 5.002e+06
+# HELP node_power_supply_present present value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_present gauge
+node_power_supply_present{power_supply="BAT0"} 1
+# HELP node_power_supply_voltage_min_design voltage_min_design value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_voltage_min_design gauge
+node_power_supply_voltage_min_design{power_supply="BAT0"} 1.08e+07
+# HELP node_power_supply_voltage_now voltage_now value of /sys/class/power_supply/<power_supply>.
+# TYPE node_power_supply_voltage_now gauge
+node_power_supply_voltage_now{power_supply="BAT0"} 1.166e+07
 # HELP node_pressure_cpu_waiting_seconds_total Total time in seconds that processes have waited for CPU time
 # TYPE node_pressure_cpu_waiting_seconds_total counter
 node_pressure_cpu_waiting_seconds_total 14.036781000000001
@@ -2481,6 +2515,7 @@
 node_scrape_collector_success{collector="netstat"} 1
 node_scrape_collector_success{collector="nfs"} 1
 node_scrape_collector_success{collector="nfsd"} 1
+node_scrape_collector_success{collector="powersupplyclass"} 1
 node_scrape_collector_success{collector="pressure"} 1
 node_scrape_collector_success{collector="processes"} 1
 node_scrape_collector_success{collector="qdisc"} 1

SuperQ

Mostly good. I would like to adjust some of the exposed metrics and names to better fit with Prometheus naming conventions and best practices.

See: https://prometheus.io/docs/practices/naming/

collector/powersupplyclass.go

shaardie · 2019-09-02T21:23:35Z

Unfortunately procfs seems to be broken since the refactoring. I created a pull request prometheus/procfs#206 to fix this. After that I could add the proposals to this.

shaardie · 2019-09-08T08:38:06Z

The pull request to procfs was accepted, so the version has to be update to be able to include this.

pgier · 2019-09-17T14:29:52Z

@shaardie procfs has been updated, so you should be good to go on this.

discordianfish

Great! LGTM

shaardie · 2019-10-15T21:38:43Z

Is there anything I can do to speed this up?

discordianfish · 2019-10-27T10:29:13Z

We still need another review, sorry!
@SuperQ or @pgier can approve and merge it.

collector/powersupplyclass.go

commit 5ef96388a978c54173e1b1ec8e7bcb41fc7d130d Author: Sven Haardiek <[email protected]> Date: Wed Sep 18 20:45:23 2019 +0200 block variables Signed-off-by: Sven Haardiek <[email protected]> commit c1177382e241994618a8ab7dd9842027d597b0df Author: Sven Haardiek <[email protected]> Date: Wed Sep 18 20:38:33 2019 +0200 Use SI Units Signed-off-by: Sven Haardiek <[email protected]> commit 04e4f99c423872d3094f21f89a8235b233a01941 Merge: 5417c98 f3538e1 Author: Sven Haardiek <[email protected]> Date: Wed Sep 18 19:20:17 2019 +0200 Merge branch 'master' into power_supply_class commit 5417c9820a40b37b490caedeaa3526883380b9bf Author: Sven Haardiek <[email protected]> Date: Wed Sep 4 23:02:39 2019 +0200 Drop averages Signed-off-by: Sven Haardiek <[email protected]> commit 1f1447dbe7bbdcdabebf4c968beb14c67d89dd9f Author: Sven Haardiek <[email protected]> Date: Wed Sep 4 22:56:00 2019 +0200 Update Copyright Signed-off-by: Sven Haardiek <[email protected]> commit 9677425059a3bf61cd7498cf7b5f05d5af7a626b Merge: 0b51589 d3478a2 Author: Sven Haardiek <[email protected]> Date: Mon Sep 2 22:02:53 2019 +0200 Merge branch 'master' into power_supply_class commit 0b51589f390cc1b33ea4728d85fca3a3b231cf3f Author: PrometheusBot <[email protected]> Date: Fri Aug 30 13:32:17 2019 +0200 makefile: update Makefile.common with newer version (prometheus#1466) Signed-off-by: prombot <[email protected]> commit af2b9e849c7b69237b7fa0e9a289c929ec7173a0 Author: Boris Momčilović <[email protected]> Date: Tue Aug 27 14:24:11 2019 +0200 Ipvs firewall mark (prometheus#1455) * IPVS: include firewall mark label Signed-off-by: Boris Momčilović <[email protected]> commit 773f99de7f699900a00b4d35340e356fe7098ee7 Author: Paul Gier <[email protected]> Date: Tue Aug 27 02:26:19 2019 -0500 update procfs to v0.0.4 (prometheus#1457) Signed-off-by: Paul Gier <[email protected]> commit 6f8a4f4348f62700cbf7eeb2657851237e13c35d Author: beorn7 <[email protected]> Date: Tue Aug 20 18:49:12 2019 +0200 Update legendLink This still had the 'k8s' in as it was copied and pasted from the kubernetes-mixin. Signed-off-by: beorn7 <[email protected]> commit d758cf394cfbed9e87e116a24d72050066cd039a Author: beorn7 <[email protected]> Date: Wed Aug 14 22:24:24 2019 +0200 Make the severity of "critical" alerts configurable This addresses the blissful scenario where single-node failures are unproblematic. No reason to wake somebody up if a node is about to screw itself up by filling the disk. Signed-off-by: beorn7 <[email protected]> commit 041b9e1e785f5f43bbef97c0c76d205181d08890 Author: beorn7 <[email protected]> Date: Thu Aug 15 16:43:57 2019 +0200 Add line for number of cores to load graph Backported from the node dashboard in the kubernetes-mixin. Signed-off-by: beorn7 <[email protected]> commit 5552bb3a6b2be1e3dd1a93dbdb9650bd0363a922 Author: beorn7 <[email protected]> Date: Thu Aug 15 16:36:10 2019 +0200 Fix title of CPU panel to usage We use the `mode="idle"` metric, but we are inverting it, so this is usage, and that's intended. Signed-off-by: beorn7 <[email protected]> commit db0571b402233323ed7e222e53f7ef7738520f49 Author: beorn7 <[email protected]> Date: Thu Aug 15 16:32:54 2019 +0200 node-mixin: Improve disk usage panel - Use a stacked graph instead of a gauge as development over time is especially useful for disk space usage. - By only taking one metric per device into account, we avoid double-counting for devices that are mounted multiple times. Signed-off-by: beorn7 <[email protected]> commit 3822e096c5d27d06b9c9a68beff81ef23f12eb36 Author: Björn Rabenstein <[email protected]> Date: Thu Aug 15 00:40:51 2019 +0200 node-mxin: Improve nodes dashboard (prometheus#1448) * node-mixin: Improve nodes dashboard - Use stacking where it makes sense. - Normalize idle CPU so that stacking is more meaningful. - Consistently fill where stacking is used but don't fill where not. - Fix y axis max value for Idle CPU panel. - Fix y axis min value for memory usage panel. - Use `$__interval` for range where applicable (and set min step to 1m). - Make the right Y axis for disk I/O actually work. This is just an incremental improvements. It doesn't touch the more involved TODOs. Signed-off-by: beorn7 <[email protected]> commit fbced86b9835e1b196c15ddcac01ba3cfcf369cc Author: beorn7 <[email protected]> Date: Tue Aug 13 21:54:28 2019 +0200 node-mixin: Fix various straight-forward issues in the USE dashboards - Normalize cluster memory utilisation. - Fix missing `1m` in memory saturation. - Have both disk-related row next to each other instead with the network row in between. - Correctly render transmit network traffic as negative, using `seriesOverrides` and `min: null` for the y-axis. - Make panel and row naming consistent. - Remove legend where it would just display a single entry with exactly the title of the panel. - Fix metric name in individual node CPU Saturation panel. - Break up disk space utilisation by device in the panel for an individual node. NB: All of that doesn't touch any more subtle issues captured in the various TODOs. Signed-off-by: beorn7 <[email protected]> commit 5bdf0625023cf7d05e0f65c6b6a1303637772ca6 Author: Sandro Jäckel <[email protected]> Date: Wed Aug 7 09:19:20 2019 +0200 Update rootfs syntax in Docker example (prometheus#1443) Signed-off-by: Sandro Jäckel <[email protected]> commit b59f081d45a3ca65957900ec33772dca25a3066f Author: Phil Frost <[email protected]> Date: Tue Aug 6 13:08:06 2019 -0400 Fix seconds reported by schedstat (prometheus#1426) Upstream bugfix: prometheus/procfs#191 Signed-off-by: Phil Frost <[email protected]> commit ac9a059ae81fa31f9963614483af3b5e3bfd672c Author: Sven Haardiek <[email protected]> Date: Sun Aug 4 20:15:36 2019 +0200 Try to make it work for PowerPC Signed-off-by: Sven Haardiek <[email protected]> commit c81acf3b009e8538783489d1468f33faf65d8b01 Merge: c064116 75462bf Author: Sven Haardiek <[email protected]> Date: Sun Aug 4 20:14:16 2019 +0200 Merge remote-tracking branch 'upstream/master' into power_supply_class Signed-off-by: Sven Haardiek <[email protected]> commit c0641162c3a432f29df30c8d0632a7756d7d2bff Merge: 06f6e3e 0b710bb Author: Sven Haardiek <[email protected]> Date: Fri Aug 2 18:30:28 2019 +0200 Merge branch 'master' into power_supply_class Signed-off-by: Sven Haardiek <[email protected]> commit 06f6e3e8b2a9b2e3f345b6d312a777731bb4b403 Author: Sven Haardiek <[email protected]> Date: Fri Mar 22 15:36:03 2019 +0100 Fix Pull Request comments * concise metric conditions * combine info about power supply to one metric Signed-off-by: Sven Haardiek <[email protected]> commit 785c3735c4626de56f8341f800ab7bb5e2594d08 Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 18:47:52 2019 +0100 Use sys.ttar instead of uploading the files Signed-off-by: Sven Haardiek <[email protected]> commit e07bff5d938457147b9009aef7d42d763018cd66 Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 18:34:50 2019 +0100 Add information about from /sys/class/power_supply Signed-off-by: Sven Haardiek <[email protected]> commit 55b3e34840c9dfc6513ae8e69b6479d5842a3091 Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 18:09:45 2019 +0100 Use cyclecount instead of cycle_count since it is a gauge Signed-off-by: Sven Haardiek <[email protected]> commit 602350b333cf9353d2cd0ffd40206c96ffe29941 Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 18:09:25 2019 +0100 other build options Signed-off-by: Sven Haardiek <[email protected]> commit 5aa38f678451d5b63ffdc32336345a1ff6703725 Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 18:08:56 2019 +0100 Update fixtures Signed-off-by: Sven Haardiek <[email protected]> commit c6acc474a4224b8d9f7b178d0d2e02636d8629ea Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 17:20:30 2019 +0100 Update command line parameter flag Signed-off-by: Sven Haardiek <[email protected]> commit f5a329e6ae5ed3b16aa866d67b944f1a73edfe42 Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 17:20:06 2019 +0100 Update procfs dependency Signed-off-by: Sven Haardiek <[email protected]> commit 38d5fa5165643d6a44dc863b3a1696774259ac0d Merge: 5a7ce69 28f3582 Author: Sven Haardiek <[email protected]> Date: Sat Mar 9 16:28:29 2019 +0100 Merge branch 'power_supply_class' of github.com:shaardie/node_exporter into power_supply_class commit 5a7ce69505079c9c090e44448cfbd7ffb2b04df7 Author: Sven Haardiek <[email protected]> Date: Sat Oct 20 18:55:49 2018 +0200 Updated Metrics of Power Supply Class Signed-off-by: Sven Haardiek <[email protected]> commit 690ab1b9c1f2e183b7088cf81c7f266d85ee6df6 Author: Sven Haardiek <[email protected]> Date: Fri Oct 19 20:03:42 2018 +0200 Start work on Power Supply Collector Signed-off-by: Sven Haardiek <[email protected]> commit 28f358222bbac4315fbf44d94da36d4b0ff2ed55 Author: Sven Haardiek <[email protected]> Date: Sat Oct 20 18:55:49 2018 +0200 Updated Metrics of Power Supply Class Signed-off-by: Sven Haardiek <[email protected]> commit 751d99b818503e9a4430b10c39760f180349b294 Author: Sven Haardiek <[email protected]> Date: Fri Oct 19 20:03:42 2018 +0200 Start work on Power Supply Collector Signed-off-by: Sven Haardiek <[email protected]> Signed-off-by: Sven Haardiek <[email protected]>

shaardie · 2019-10-27T15:17:09Z

@SuperQ I changed what you asked for.

SuperQ

LGTM, Thanks!

* The netdev collector CLI argument `--collector.netdev.ignored-devices` was renamed to `--collector.netdev.device-blacklist` in order to conform with the systemd collector. #1279 * The label named `state` on `node_systemd_service_restart_total` metrics was changed to `name` to better describe the metric. #1393 * Refactoring of the mdadm collector changes several metrics - `node_md_disks_active` is removed - `node_md_disks` now has a `state` label for "fail", "spare", "active" disks. - `node_md_is_active` is replaced by `node_md_state` with a state set of "active", "inactive", "recovering", "resync". * Additional label `mountaddr` added to NFS device metrics to distinguish mounts from the same URL, but different IP addresses. #1417 * Metrics node_cpu_scaling_frequency_min_hrts and node_cpu_scaling_frequency_max_hrts of the cpufreq collector were renamed to node_cpu_scaling_frequency_min_hertz and node_cpu_scaling_frequency_max_hertz. #1510 * Collectors that are enabled, but are unable to find data to collect, now return 0 for `node_scrape_collector_success`. * [CHANGE] Add `--collector.netdev.device-whitelist`. #1279 * [CHANGE] Ignore iso9600 filesystem on Linux #1355 * [CHANGE] Refactor mdadm collector #1403 * [CHANGE] Add `mountaddr` label to NFS metrics. #1417 * [CHANGE] Don't count empty collectors as success. #1613 * [FEATURE] New flag to disable default collectors #1276 * [FEATURE] Add experimental TLS support #1277, #1687, #1695 * [FEATURE] Add collector for Power Supply Class #1280 * [FEATURE] Add new schedstat collector #1389 * [FEATURE] Add FreeBSD zfs support #1394 * [FEATURE] Add uname support for Darwin and OpenBSD #1433 * [FEATURE] Add new metric node_cpu_info #1489 * [FEATURE] Add new thermal_zone collector #1425 * [FEATURE] Add new cooling_device metrics to thermal zone collector #1445 * [FEATURE] Add swap usage on darwin #1508 * [FEATURE] Add Btrfs collector #1512 * [FEATURE] Add RAPL collector #1523 * [FEATURE] Add new softnet collector #1576 * [FEATURE] Add new udp_queues collector #1503 * [FEATURE] Add basic authentication #1673 * [ENHANCEMENT] Log pid when there is a problem reading the process stats #1341 * [ENHANCEMENT] Collect InfiniBand port state and physical state #1357 * [ENHANCEMENT] Include additional XFS runtime statistics. #1423 * [ENHANCEMENT] Report non-fatal collection errors in the exporter metric. #1439 * [ENHANCEMENT] Expose IPVS firewall mark as a label #1455 * [ENHANCEMENT] Add check for systemd version before attempting to query certain metrics. #1413 * [ENHANCEMENT] Add a flag to adjust mount timeout #1486 * [ENHANCEMENT] Add new counters for flush requests in Linux 5.5 #1548 * [ENHANCEMENT] Add metrics and tests for UDP receive and send buffer errors #1534 * [ENHANCEMENT] The sockstat collector now exposes IPv6 statistics in addition to the existing IPv4 support. #1552 * [ENHANCEMENT] Add infiniband info metric #1563 * [ENHANCEMENT] Add unix socket support for supervisord collector #1592 * [ENHANCEMENT] Implement loadavg on all BSDs without cgo #1584 * [ENHANCEMENT] Add model_name and stepping to node_cpu_info metric #1617 * [ENHANCEMENT] Add `--collector.perf.cpus` to allow setting the CPU list for perf stats. #1561 * [ENHANCEMENT] Add metrics for IO errors and retires on Darwin. #1636 * [ENHANCEMENT] Add perf tracepoint collection flag #1664 * [ENHANCEMENT] ZFS: read contents of objset file #1632 * [ENHANCEMENT] Linux CPU: Cache CPU metrics to make them monotonically increasing #1711 * [BUGFIX] Read /proc/net files with a single read syscall #1380 * [BUGFIX] Renamed label `state` to `name` on `node_systemd_service_restart_total`. #1393 * [BUGFIX] Fix netdev nil reference on Darwin #1414 * [BUGFIX] Strip path.rootfs from mountpoint labels #1421 * [BUGFIX] Fix seconds reported by schedstat #1426 * [BUGFIX] Fix empty string in path.rootfs #1464 * [BUGFIX] Fix typo in cpufreq metric names #1510 * [BUGFIX] Read /proc/stat in one syscall #1538 * [BUGFIX] Fix OpenBSD cache memory information #1542 * [BUGFIX] Refactor textfile collector to avoid looping defer #1549 * [BUGFIX] Fix network speed math #1580 * [BUGFIX] collector/systemd: use regexp to extract systemd version #1647 * [BUGFIX] Fix initialization in perf collector when using multiple CPUs #1665 * [BUGFIX] Fix accidentally empty lines in meminfo_linux #1671 Signed-off-by: Ben Kochie <[email protected]>

* The netdev collector CLI argument `--collector.netdev.ignored-devices` was renamed to `--collector.netdev.device-blacklist` in order to conform with the systemd collector. prometheus#1279 * The label named `state` on `node_systemd_service_restart_total` metrics was changed to `name` to better describe the metric. prometheus#1393 * Refactoring of the mdadm collector changes several metrics - `node_md_disks_active` is removed - `node_md_disks` now has a `state` label for "fail", "spare", "active" disks. - `node_md_is_active` is replaced by `node_md_state` with a state set of "active", "inactive", "recovering", "resync". * Additional label `mountaddr` added to NFS device metrics to distinguish mounts from the same URL, but different IP addresses. prometheus#1417 * Metrics node_cpu_scaling_frequency_min_hrts and node_cpu_scaling_frequency_max_hrts of the cpufreq collector were renamed to node_cpu_scaling_frequency_min_hertz and node_cpu_scaling_frequency_max_hertz. prometheus#1510 * Collectors that are enabled, but are unable to find data to collect, now return 0 for `node_scrape_collector_success`. * [CHANGE] Add `--collector.netdev.device-whitelist`. prometheus#1279 * [CHANGE] Ignore iso9600 filesystem on Linux prometheus#1355 * [CHANGE] Refactor mdadm collector prometheus#1403 * [CHANGE] Add `mountaddr` label to NFS metrics. prometheus#1417 * [CHANGE] Don't count empty collectors as success. prometheus#1613 * [FEATURE] New flag to disable default collectors prometheus#1276 * [FEATURE] Add experimental TLS support prometheus#1277, prometheus#1687, prometheus#1695 * [FEATURE] Add collector for Power Supply Class prometheus#1280 * [FEATURE] Add new schedstat collector prometheus#1389 * [FEATURE] Add FreeBSD zfs support prometheus#1394 * [FEATURE] Add uname support for Darwin and OpenBSD prometheus#1433 * [FEATURE] Add new metric node_cpu_info prometheus#1489 * [FEATURE] Add new thermal_zone collector prometheus#1425 * [FEATURE] Add new cooling_device metrics to thermal zone collector prometheus#1445 * [FEATURE] Add swap usage on darwin prometheus#1508 * [FEATURE] Add Btrfs collector prometheus#1512 * [FEATURE] Add RAPL collector prometheus#1523 * [FEATURE] Add new softnet collector prometheus#1576 * [FEATURE] Add new udp_queues collector prometheus#1503 * [FEATURE] Add basic authentication prometheus#1673 * [ENHANCEMENT] Log pid when there is a problem reading the process stats prometheus#1341 * [ENHANCEMENT] Collect InfiniBand port state and physical state prometheus#1357 * [ENHANCEMENT] Include additional XFS runtime statistics. prometheus#1423 * [ENHANCEMENT] Report non-fatal collection errors in the exporter metric. prometheus#1439 * [ENHANCEMENT] Expose IPVS firewall mark as a label prometheus#1455 * [ENHANCEMENT] Add check for systemd version before attempting to query certain metrics. prometheus#1413 * [ENHANCEMENT] Add a flag to adjust mount timeout prometheus#1486 * [ENHANCEMENT] Add new counters for flush requests in Linux 5.5 prometheus#1548 * [ENHANCEMENT] Add metrics and tests for UDP receive and send buffer errors prometheus#1534 * [ENHANCEMENT] The sockstat collector now exposes IPv6 statistics in addition to the existing IPv4 support. prometheus#1552 * [ENHANCEMENT] Add infiniband info metric prometheus#1563 * [ENHANCEMENT] Add unix socket support for supervisord collector prometheus#1592 * [ENHANCEMENT] Implement loadavg on all BSDs without cgo prometheus#1584 * [ENHANCEMENT] Add model_name and stepping to node_cpu_info metric prometheus#1617 * [ENHANCEMENT] Add `--collector.perf.cpus` to allow setting the CPU list for perf stats. prometheus#1561 * [ENHANCEMENT] Add metrics for IO errors and retires on Darwin. prometheus#1636 * [ENHANCEMENT] Add perf tracepoint collection flag prometheus#1664 * [ENHANCEMENT] ZFS: read contents of objset file prometheus#1632 * [ENHANCEMENT] Linux CPU: Cache CPU metrics to make them monotonically increasing prometheus#1711 * [BUGFIX] Read /proc/net files with a single read syscall prometheus#1380 * [BUGFIX] Renamed label `state` to `name` on `node_systemd_service_restart_total`. prometheus#1393 * [BUGFIX] Fix netdev nil reference on Darwin prometheus#1414 * [BUGFIX] Strip path.rootfs from mountpoint labels prometheus#1421 * [BUGFIX] Fix seconds reported by schedstat prometheus#1426 * [BUGFIX] Fix empty string in path.rootfs prometheus#1464 * [BUGFIX] Fix typo in cpufreq metric names prometheus#1510 * [BUGFIX] Read /proc/stat in one syscall prometheus#1538 * [BUGFIX] Fix OpenBSD cache memory information prometheus#1542 * [BUGFIX] Refactor textfile collector to avoid looping defer prometheus#1549 * [BUGFIX] Fix network speed math prometheus#1580 * [BUGFIX] collector/systemd: use regexp to extract systemd version prometheus#1647 * [BUGFIX] Fix initialization in perf collector when using multiple CPUs prometheus#1665 * [BUGFIX] Fix accidentally empty lines in meminfo_linux prometheus#1671 Signed-off-by: Ben Kochie <[email protected]>

discordianfish reviewed Mar 17, 2019

View reviewed changes

collector/powersupplyclass.go Outdated Show resolved Hide resolved

discordianfish reviewed Mar 17, 2019

View reviewed changes

collector/fixtures/e2e-output.txt Outdated Show resolved Hide resolved

discordianfish requested changes Mar 17, 2019

View reviewed changes

SuperQ requested changes Aug 5, 2019

View reviewed changes

discordianfish reviewed Aug 23, 2019

View reviewed changes

collector/powersupplyclass.go Outdated Show resolved Hide resolved

shaardie force-pushed the power_supply_class branch from 5ef9638 to 0c3ec1b Compare September 18, 2019 19:34

shaardie requested review from SuperQ and discordianfish September 18, 2019 19:46

discordianfish approved these changes Oct 3, 2019

View reviewed changes

SuperQ reviewed Oct 27, 2019

View reviewed changes

collector/powersupplyclass.go Outdated Show resolved Hide resolved

SuperQ reviewed Oct 27, 2019

View reviewed changes

collector/powersupplyclass.go Outdated Show resolved Hide resolved

shaardie force-pushed the power_supply_class branch from 0c3ec1b to ae36cc0 Compare October 27, 2019 15:01

shaardie force-pushed the power_supply_class branch from ae36cc0 to d089776 Compare October 27, 2019 15:03

shaardie requested a review from SuperQ October 27, 2019 15:17

SuperQ approved these changes Oct 30, 2019

View reviewed changes

SuperQ merged commit f9d2bbe into prometheus:master Oct 30, 2019

SuperQ mentioned this pull request May 25, 2020

Release 1.0.0 #1714

Merged

Conversation

shaardie commented Mar 9, 2019

Uh oh!

Uh oh!

Uh oh!

discordianfish left a comment

Choose a reason for hiding this comment

Uh oh!

shaardie commented Mar 22, 2019

Uh oh!

shaardie commented Apr 4, 2019

Uh oh!

pgier commented Jul 9, 2019

Uh oh!

discordianfish commented Jul 29, 2019

Uh oh!

shaardie commented Jul 30, 2019

Uh oh!

shaardie commented Aug 2, 2019

Uh oh!

SuperQ commented Aug 2, 2019

Uh oh!

shaardie commented Aug 2, 2019

Uh oh!

SuperQ commented Aug 4, 2019

Uh oh!

SuperQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shaardie commented Sep 2, 2019

Uh oh!

shaardie commented Sep 8, 2019

Uh oh!

pgier commented Sep 17, 2019

Uh oh!

discordianfish left a comment

Choose a reason for hiding this comment

Uh oh!

shaardie commented Oct 15, 2019

Uh oh!

discordianfish commented Oct 27, 2019

Uh oh!

Uh oh!

Uh oh!

shaardie commented Oct 27, 2019

Uh oh!

SuperQ left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants