Hi!

In prometheus/procfs#100, I added support for UDP NFS mounts in the mountstats module. This introduces a new tag called protocol to the NFSTransportStats struct.

I already wrote some code to get this new tag into the node exporter. This made it necessary to update the logic for detecting the same export on multiple distinct mountpoints (see

), because the same export can be mounted with different protocols.

It works like this: Currently, the logic checks for the same Device, which is the NFS export name. The change would instead checks for the tuple (Device, Protocol), with both fields being the same.

I saw #993, which also references the duplicate detection logic. Because I already touched that piece of code, I could use the tuple (Device, Protocol, Version) instead.

How do we proceed here? How do we update vendored dependencies?

I would then create a pull request with my changes so we can review them together.