Skip to content

Don't return success for collectors that have no data to return #1323

@SuperQ

Description

@SuperQ

We currently return true in node_scrape_collector_success for collectors that are enabled, but the underlying kernel feature is not. This is confusing for users because they can't tell that the collector returned no data.

This is especially problematic for Prometheus data model where lack of data is not an alarm.

We previously considered adding a separate metric for "enabled but empty" status, but decided against it due to the additional metrics load from the already heavy (> 500) metrics returned by this exporter.

Proposal

Collectors that are enabled but fail to gather any data should also return false for node_scrape_collector_success.

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions