Skip to content

Support Enum values#787

Merged
dhoard merged 1 commit intoprometheus:mainfrom
speedfl:feature/support-enums
Apr 21, 2023
Merged

Support Enum values#787
dhoard merged 1 commit intoprometheus:mainfrom
speedfl:feature/support-enums

Conversation

@speedfl
Copy link
Copy Markdown
Contributor

@speedfl speedfl commented Apr 19, 2023

Hello,

Some metrics are using Enum values and are rejected. It is the case for example of the kafka.streams:type=stream-metrics which contains an attribute state which can be RUNNING, REBALANCING...

Links:

In a Kafka Stream environment, we may want to know to know all streams which are not in a RUNNING state. Therefore it could be useful to do sum(kafka_streams_state_running) and compare it with the number of instances to know if all instances are RUNNING and processing.

For information I built the javaagent jar and deployed it in our environment and I was able to get answer:

image

@speedfl speedfl force-pushed the feature/support-enums branch from 93fad4c to de00953 Compare April 19, 2023 20:38
Signed-off-by: Geoffrey Muselli <[email protected]>
@speedfl speedfl force-pushed the feature/support-enums branch from de00953 to a0cfc05 Compare April 19, 2023 20:39
Copy link
Copy Markdown
Collaborator

@dhoard dhoard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepted.

@speedfl thanks for the contribution!

@dhoard dhoard merged commit bcfa34e into prometheus:main Apr 21, 2023
dhoard pushed a commit to dhoard/jmx_exporter that referenced this pull request Apr 22, 2023
Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: dhoard <[email protected]>
dupetr pushed a commit to dupetr/jmx_exporter that referenced this pull request May 12, 2023
Signed-off-by: Geoffrey Muselli <[email protected]>
Signed-off-by: Petr Dušák <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants