Adding changes to support s390x#53
Merged
sdurrheimer merged 2 commits intoprometheus:masterfrom Sep 19, 2018
Merged
Conversation
duane-ibm
force-pushed
the
golang-builder-s390x
branch
from
1167085 to
11cd944
Compare
SuperQ
reviewed
Sep 14, 2018
| @@ -0,0 +1,15 @@ | |||
| # Copyright 2016 The Prometheus Authors | |||
Member
There was a problem hiding this comment.
Please update the date for new files.
duane-ibm
force-pushed
the
golang-builder-s390x
branch
2 times, most recently
from
6f07d5a to
459af02
Compare
Member
|
Strange, the build is failing due to |
Member
Contributor
|
Why the |
Member
|
|
Contributor
Author
|
Should i change the |
Member
|
Yes, please name the files |
Signed-off-by: duane-ibm <[email protected]>
duane-ibm
force-pushed
the
golang-builder-s390x
branch
from
04b3ad6 to
bc0a3d0
Compare
Contributor
Author
|
Naming conventions changed to use |
Contributor
|
@duane-ibm With #51, we have replaced Go 1.9 with Go 1.11. Could you edit your commit to reflect this change ? |
Contributor
Author
|
@sdurrheimer will do it. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added changes to create golang-builder-z docker image for s390x.
Can someone please review the changes?