Skip to content

Add support for go 1.11#51

Merged
sdurrheimer merged 2 commits intoprometheus:masterfrom
simonpasquier:add-go-1.11
Sep 18, 2018
Merged

Add support for go 1.11#51
sdurrheimer merged 2 commits intoprometheus:masterfrom
simonpasquier:add-go-1.11

Conversation

@simonpasquier
Copy link
Copy Markdown
Member

Closes #49

Signed-off-by: Simon Pasquier <[email protected]>
@sdurrheimer
Copy link
Copy Markdown
Contributor

Thank you, I will take a look more deeply as soon as possible.

@simonpasquier
Copy link
Copy Markdown
Member Author

@sdurrheimer this isn't directly related to this PR but the CI failed because OSXCROSS_SDK_URL isn't set (https://circleci.com/gh/prometheus/golang-builder/165). This relates probably to the migration from Circle CI 1.0 to 2.0 and the fact that by default, builds from forked pull requests can't access secrets (see https://circleci.com/docs/2.0/oss/#pass-secrets-to-builds-from-forked-pull-requests). I've pushed my branch to the parent repository and it solves the issue for me but any external contributor will be impacted AFAICT.

@sdurrheimer
Copy link
Copy Markdown
Contributor

LGTM but usually we only keep 2 golang versions. We should probably remove Go 1.9.

@simonpasquier
Copy link
Copy Markdown
Member Author

I thought that node_exporter was still using 1.9 but it isn't the case anymore since a month ago. I'll amend the PR to keep only 1.10 and 1.11.

@SuperQ
Copy link
Copy Markdown
Member

SuperQ commented Sep 17, 2018

Yes, we think we may have gotten to the bottom of the 1.10.x CGO crashing. At worst, we've disabled the collector that appears to be the problem.

Signed-off-by: Simon Pasquier <[email protected]>
Copy link
Copy Markdown
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@sdurrheimer sdurrheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdurrheimer sdurrheimer merged commit 59dd804 into prometheus:master Sep 18, 2018
@simonpasquier simonpasquier deleted the add-go-1.11 branch February 26, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants