feat: impl<T: Collector> Collector for std::sync::Arc<T>#273
Merged
mxinden merged 2 commits intoprometheus:masterfrom Aug 14, 2025
Merged
feat: impl<T: Collector> Collector for std::sync::Arc<T>#273mxinden merged 2 commits intoprometheus:masterfrom
mxinden merged 2 commits intoprometheus:masterfrom
Conversation
mxinden
reviewed
Aug 14, 2025
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Change looks good to me. Thanks.
You would need to add a git --signoff to your commit in order for us to merge.
Signed-off-by: hanabi1224 <[email protected]>
Signed-off-by: hanabi1224 <[email protected]>
hanabi1224
force-pushed
the
impl-collector-for-arc
branch
from
80fe980 to
76d7b30
Compare
mxinden
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
Collectorforstd::sync::Arc<T>whereT: Collector. This is useful for registering anArcpointer of the metrics collector instead of wrapping collector fields withArc