Add minimal version of golang/protobuf in dep config for Go#25
Add minimal version of golang/protobuf in dep config for Go#25qneyrat wants to merge 2 commits intoprometheus:masterfrom
Conversation
Signed-off-by: qneyrat <[email protected]>
|
Thanks for the PR. The problem here is that we already had many back-and-forth iterations adding and removing vendoring in libraries. Last time we discussed this, my impression was that the Go community strongly discourages vendoring in libraries. I would like to see firm evidence that this has changed before adding vendored dependencies once more. Do you know of anything like that? |
Signed-off-by: qneyrat <[email protected]>
|
Dep |
73172e0 to
0dc082c
Compare
|
maybe it's important to fix dependencies versions in prometheus/client_golang |
I'm not sure what you mean by that. client_golang is a library, too, so we don't vendor there, either. (We in fact did, and then removed it again after much discussion.) About the I would also like to understand the problem better. If I just do a |
|
I interpret the silence as "there is indeed nothing we can do right now until there is a commonly adopted solution to dependency management in Go". I'll close this now, but feel free to follow up later. |
Fix version of golang/protobuf because can use older version.
Example:
proto.InternalMessageInfoisn't declare in golang/protobuf 1.0.0