-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Optionally add OM unit #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Optionally add OM unit #1392
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
d74a7fb
start adding support for units
vesari 5d8c6de
do not assume units for now
vesari f78b666
again, do not assume units
vesari e876012
assume the units
vesari b1f5a86
add units in more places
vesari 788d53b
fix dependencies in go.mod
vesari 1692495
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 5971215
Update version of common in go.mod
vesari efb64f3
Start modifying handler
vesari fafe45b
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 51861d5
Use different common
vesari 1362436
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari a2bfd3a
Use the newly named func for OM encoding
vesari 7900714
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 19d7102
Fix examples and comments
vesari 031e0d3
Fix go.mod
vesari fd60a57
Adapt go.mod as much as possible
vesari f7e2848
Use go 1.20
vesari 5f58996
Use go 1.21
vesari ac9d1d8
Upgrade github workflows to go 1.21 needed for common
vesari 3db440e
Delete test funcs which are unused according to lint
vesari 7752d37
Upgrade to Go 1.21 in Makefile and workflows for tests
vesari 47c8cf1
Upgrade Go version to 1.21 in tutorial
vesari 7312bd5
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 3644321
Adapt to forthcoming new handlers options, reinstate support for old Go
vesari dca67a5
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari ab34546
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 717d3d3
Update prometheus/promhttp/http.go
vesari 5b5c4be
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari a635a5a
small cleanup
vesari e5f8851
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 9eac68e
Make desc funcs variadic
vesari 3441cb0
Adjust http to have unit and test accordingly
vesari 52eb82d
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 99ae579
Update prometheus/metric.go
vesari 1d93cb8
Update prometheus/promhttp/http.go
vesari 00d2201
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 5a07918
Fix formatting
vesari 7b8aec9
Add tests for unit edge cases, ensure unit field is skipped if no uni…
vesari 2efe1b8
Restore original NewDesc signature, replace unit with DescOpt variadi…
vesari 38444fe
Eval unit asap
vesari 3dac913
test runtime metrics unit extraction
vesari 410798a
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari b1a1b98
reference modified common code, remove unit flag, adapt tests
vesari 7161200
Adopt version of common with the unit flag removed
vesari 1c09fe5
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 2df0d58
Fix merge conflicts
vesari 00d3a11
Update prometheus/desc.go
vesari 8e9fca4
Always show unit in Desc.String() output + miscellaneous
vesari 03898e0
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari fdb3b1d
Align go.sum
vesari 634541a
Merge remote-tracking branch 'prometheus/main' into add-unit
vesari 6959e0c
Solve conflict
vesari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.