Use pedantic registry in other places too, to double check.

bwplotka · bwplotka · commit f2dd7b35fd3f · 2024-08-20T11:44:35.000+01:00
Signed-off-by: bwplotka &lt;bwplotka@gmail.com&gt;
diff --git a/prometheus/collectors/dbstats_collector_test.go b/prometheus/collectors/dbstats_collector_test.go
@@ -21,7 +21,7 @@ import (
 )
 
 func TestDBStatsCollector(t *testing.T) {
-	reg := prometheus.NewRegistry()
+	reg := prometheus.NewPedanticRegistry()
 	{
 		db := new(sql.DB)
 		if err := reg.Register(NewDBStatsCollector(db, "db_A")); err != nil {
diff --git a/prometheus/collectors/go_collector_latest_test.go b/prometheus/collectors/go_collector_latest_test.go
@@ -63,7 +63,7 @@ var memstatMetrics = []string{
 }
 
 func TestGoCollectorMarshalling(t *testing.T) {
-	reg := prometheus.NewRegistry()
+	reg := prometheus.NewPedanticRegistry()
 	reg.MustRegister(NewGoCollector(
 		WithGoCollectorRuntimeMetrics(GoRuntimeMetricsRule{
 			Matcher: regexp.MustCompile("/.*"),
@@ -80,7 +80,7 @@ func TestGoCollectorMarshalling(t *testing.T) {
 }
 
 func TestWithGoCollectorDefault(t *testing.T) {
-	reg := prometheus.NewRegistry()
+	reg := prometheus.NewPedanticRegistry()
 	reg.MustRegister(NewGoCollector())
 	result, err := reg.Gather()
 	if err != nil {
@@ -100,7 +100,7 @@ func TestWithGoCollectorDefault(t *testing.T) {
 }
 
 func TestWithGoCollectorMemStatsMetricsDisabled(t *testing.T) {
-	reg := prometheus.NewRegistry()
+	reg := prometheus.NewPedanticRegistry()
 	reg.MustRegister(NewGoCollector(
 		WithGoCollectorMemStatsMetricsDisabled(),
 	))
@@ -157,7 +157,7 @@ func TestGoCollectorAllowList(t *testing.T) {
 		},
 	} {
 		t.Run(test.name, func(t *testing.T) {
-			reg := prometheus.NewRegistry()
+			reg := prometheus.NewPedanticRegistry()
 			reg.MustRegister(NewGoCollector(
 				WithGoCollectorMemStatsMetricsDisabled(),
 				WithGoCollectorRuntimeMetrics(test.rules...),
@@ -219,7 +219,7 @@ func TestGoCollectorDenyList(t *testing.T) {
 		},
 	} {
 		t.Run(test.name, func(t *testing.T) {
-			reg := prometheus.NewRegistry()
+			reg := prometheus.NewPedanticRegistry()
 			reg.MustRegister(NewGoCollector(
 				WithGoCollectorMemStatsMetricsDisabled(),
 				WithoutGoCollectorRuntimeMetrics(test.matchers...),
@@ -242,7 +242,7 @@ func TestGoCollectorDenyList(t *testing.T) {
 }
 
 func ExampleGoCollector() {
-	reg := prometheus.NewRegistry()
+	reg := prometheus.NewPedanticRegistry()
 
 	// Register the GoCollector with the default options. Only the base metrics, default runtime metrics and memstats are enabled.
 	reg.MustRegister(NewGoCollector())
@@ -252,7 +252,7 @@ func ExampleGoCollector() {
 }
 
 func ExampleGoCollector_WithAdvancedGoMetrics() {
-	reg := prometheus.NewRegistry()
+	reg := prometheus.NewPedanticRegistry()
 
 	// Enable Go metrics with pre-defined rules. Or your custom rules.
 	reg.MustRegister(

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ import (`
`21`	`21`	`)`
`22`	`22`
`23`	`23`	`func TestDBStatsCollector(t *testing.T) {`
`24`		`- reg := prometheus.NewRegistry()`
	`24`	`+ reg := prometheus.NewPedanticRegistry()`
`25`	`25`	`{`
`26`	`26`	`db := new(sql.DB)`
`27`	`27`	`if err := reg.Register(NewDBStatsCollector(db, "db_A")); err != nil {`