Issue 609 2#711
Closed
prymitive wants to merge 8 commits intoprometheus:masterfrom
prymitive:issue-609-2
Closed
Conversation
This will be used to track and expose the status of an alert, it will replace dedicated fields in the Marker
| inhibited | ||
| ) | ||
|
|
||
| // allows tracking of the status of an alert (active, silenced, ) |
Contributor
There was a problem hiding this comment.
Please follow go style for comments on exported package members https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences
Merged
Contributor
|
I finally got to looking at your changes and really like the direction. I hacked around on it a bit, see what you think. I opened a pr, but I've also attached a patch file that you can check out. |
Contributor
Author
|
Great, I'll close this one as #717 is more complete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt at solving #609, previous PR was #692
This is still work in progress, changes here are complete but:
newinstead ofunprocessed?)