use promauto to register silence state metrics#4865
Merged
Conversation
Signed-off-by: SungJin1212 <[email protected]>
SungJin1212
force-pushed
the
migrate-silences-to-promauto
branch
from
January 5, 2026 01:29
29e76f6 to
b7f446d
Compare
Contributor
Author
|
@SuperQ |
ultrotter
approved these changes
Jan 9, 2026
TheMeier
approved these changes
Jan 9, 2026
SuperQ
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While #4700 migrated most metrics to use
promautofor automatic registration, thealertmanager_silencesmetrics (Active, Pending, Expired) generated bynewSilenceMetricByStatewere missed.This PR migrate missed metric to use
promauto.