Skip to content

Conversation

@gotjosh
Copy link
Member

@gotjosh gotjosh commented Jun 14, 2024

Reverts #3531

@gotjosh
Copy link
Member Author

gotjosh commented Jun 14, 2024

@TheMeier this did break the tests - Let's revert it for now until I have some time to figure out what's wrong?

@grobinson-grafana
Copy link
Collaborator

There are two imports for error package with the same name:

package sns

import (
	"errors"
	...

	"github.com/pkg/errors"
)
`errors` redeclared in this block (typecheck)

see 603a728.

@grobinson-grafana
Copy link
Collaborator

We should also replace errors.Wrap with fmt.Errorf 🙂 @emanlodovice

@gotjosh gotjosh merged commit 7e2cd80 into main Jun 14, 2024
@gotjosh gotjosh deleted the revert-3531-sns-raise-template-error branch June 14, 2024 09:27
@emanlodovice
Copy link
Contributor

My apologies for the previous PR, it was old and needed to be rebase. I have opened a new PR to fix the issue #3879 . Please have a look. Thank you.

TheMeier pushed a commit to TheMeier/alertmanager that referenced this pull request Sep 29, 2024
tjhop pushed a commit to tjhop/alertmanager that referenced this pull request Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants