add typescript definitions#231
add typescript definitions#231blushingpenguin wants to merge 11 commits intoprojectfluent:masterfrom
Conversation
|
IMHO it's extremely necessary to add support for typescript in fluent, please accept this PR, or add |
|
@blushingpenguin Sorry I haven't looked at this earlier. Is there some way to make sure type definitions stay up to date as we continue making changes to |
|
@stasm Another solution would be to just use Typescript for the test files and use the manually written definitions. Overall, I agree that type definitions are very valuable, especially for consumers: they improve code completion and enable static checks. If you're interested, I could try to send a minimal PR to convert the project to TS: do not change the code, just add the compiler. |
I'd describe myself as cautious when it comes to converting
I like this idea a lot. The API surface is small enough that it might just work.
I'm sorry for not replying earlier. I'm very interested in doing something to help TypeScript users use Fluent. I also have more time to tend to this project, now that Fluent Syntax 0.8 has been released. If you add the compiler, what will the consequences for the code in |
|
Hi, I'll try to send a PR building on top of this one. |
|
These definitions are out of date and subsequently definitions were submitted to DefinitelyTyped (of which those definitions are now also out of date!). I have submitted some up to date definitions to DT so this PR isn't useful anymore. |
This adds typescript definition files (.d.ts) which allow fluent-react to be used from typescript easily