Skip to content

Add ability to set config from env vars #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mzack9999 merged 4 commits into from
May 14, 2023
Merged

Add ability to set config from env vars #149

Mzack9999 merged 4 commits into from
May 14, 2023

Conversation

@iamargus95
Copy link
Contributor

@iamargus95 iamargus95 commented May 9, 2023

  • Add helper func to set config from env vars

@iamargus95 iamargus95 mentioned this pull request May 9, 2023
Merged
6 tasks
@iamargus95 iamargus95 marked this pull request as draft May 9, 2023 09:01
@iamargus95
fix ranging over channel
51b50f5 
Signed-off-by: iamargus95 <[email protected]>
@iamargus95 iamargus95 marked this pull request as ready for review May 9, 2023 09:08
@iamargus95
Copy link
Contributor Author

iamargus95 commented May 9, 2023 •
edited
Loading

@tarunKoyalwar Just updated the PR to fix ranging over channel. 😅

iamargus95 added 2 commits May 9, 2023 16:42
@iamargus95
rename func
933f923 
Signed-off-by: iamargus95 <[email protected]>
@iamargus95
add test cases
4c7a9c4 
Signed-off-by: iamargus95 <[email protected]>
tarunKoyalwar
tarunKoyalwar approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tarunKoyalwar tarunKoyalwar requested a review from Mzack9999 May 10, 2023 14:37
@Mzack9999 Mzack9999 merged commit bd8290f into projectdiscovery:main May 14, 2023
@Mzack9999 Mzack9999 linked an issue May 14, 2023 that may be closed by this pull request
Expand io.reader with env vars #154
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expand io.reader with env vars

3 participants

@iamargus95 @Mzack9999 @tarunKoyalwar