Skip to content

Comments

Update golang version in Dockerfile for builder stage#665

Merged
ehsandeep merged 1 commit intoprojectdiscovery:mainfrom
naksudev:dev
Apr 25, 2025
Merged

Update golang version in Dockerfile for builder stage#665
ehsandeep merged 1 commit intoprojectdiscovery:mainfrom
naksudev:dev

Conversation

@naksudev
Copy link
Contributor

@naksudev naksudev commented Mar 25, 2025 •
edited by coderabbitai bot
Loading

Fixed wrong version for builder stage being inferior to the go.mod version which leads to an error when trying to build an image.

See the error below.

$ docker build -t uncover .
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

Sending build context to Docker daemon  2.155MB
Step 1/10 : FROM golang:1.21.4-alpine AS builder
 ---> 72d77ba3e25b
Step 2/10 : RUN apk add --no-cache git build-base
 ---> Using cache
 ---> 578d58ca3908
Step 3/10 : WORKDIR /app
 ---> Using cache
 ---> c9df7bb33baf
Step 4/10 : COPY . /app
 ---> 8a88f88d04bd
Step 5/10 : RUN go mod download
 ---> Running in 54b508e30337
go: go.mod requires go >= 1.22.0 (running go 1.21.4; GOTOOLCHAIN=local)
The command '/bin/sh -c go mod download' returned a non-zero code: 1

I changed the version of golang to 1.24.1 which successfully builds the 1.0.10 version of uncover.

Summary by CodeRabbit

  • Chores
    • Updated the build process to leverage a more current runtime environment, helping enhance overall stability and compatibility for the application’s delivery. This improvement, though operating behind the scenes, supports a more robust and secure user experience.

@naksudev
Update golang version for builder stage
296c36b 
Fixed wrong version for builder stage being inferior to the go.mod
version.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 25, 2025 •
edited
Loading

Walkthrough

The Dockerfile has been modified to update the base image for the builder stage, changing it from golang:1.21.4-alpine to golang:1.24.1-alpine. This change directly affects the Go version used during the build process while all other configurations remain unchanged.

Changes

File Change Summary
Dockerfile Updated the builder stage base image from golang:1.21.4-alpine to golang:1.24.1-alpine.

Poem

I'm a merry rabbit in a code-filled glen,
Hopping around, upgrading Go again.
A fresher base, a brighter scene,
Carrots and code in a joyful routine.
Leaping high, my script's so keen!

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
Dockerfile (1)

15-15: ENTRYPOINT Configuration Review

The specification of ENTRYPOINT ["uncover"] is clear and correctly placed in the release stage. This entrypoint assumes the binary uncover exists in /usr/local/bin/ (as copied from the builder stage). If you anticipate the need for runtime arguments or flexibility, you might consider combining it with a default CMD so that the container’s behavior can be more easily overridden.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2a3198 and 296c36b.

📒 Files selected for processing (1)
  • Dockerfile (2 hunks)
🔇 Additional comments (1)
Dockerfile (1)

2-2: Golang Version Update Validation

The base image has been correctly updated to golang:1.24.1-alpine, which now satisfies the minimum Go version requirement specified in your go.mod file. Ensure that all related Go toolchain dependencies or any CI/CD pipelines are aligned with this change.

@naksudev naksudev changed the title Update golang version for builder stage Update golang version in Dockerfile for builder stage Mar 25, 2025
@GeorginaReeder
Copy link

GeorginaReeder commented Mar 26, 2025

Thanks so much for your contribution @naksudev ! :)

@ehsandeep ehsandeep merged commit f4d7a82 into projectdiscovery:main Apr 25, 2025
1 check passed
@BrewTestBot BrewTestBot mentioned this pull request Jun 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naksudev @GeorginaReeder @ehsandeep