Skip to content

Comments

fix provider config unmarshal#230

Merged
ehsandeep merged 1 commit intodevfrom
issue-229-provider-file-check
Jun 1, 2023
Merged

fix provider config unmarshal#230
ehsandeep merged 1 commit intodevfrom
issue-229-provider-file-check

Conversation

@tarunKoyalwar
Copy link
Member

@tarunKoyalwar tarunKoyalwar commented May 31, 2023

Proposed Changes

@tarunKoyalwar tarunKoyalwar self-assigned this May 31, 2023
@tarunKoyalwar tarunKoyalwar marked this pull request as ready for review May 31, 2023 21:20
@tarunKoyalwar tarunKoyalwar linked an issue May 31, 2023 that may be closed by this pull request
@tarunKoyalwar
Copy link
Member Author

steps to reproduce available at #229 (comment)

Testing PR / Patch

step 1) complete all steps in steps to reproduce
step 2) run below command after cloning nuclei dev/main branch

# replace /Users/tarun/Codebase2/uncover with filepath of this PR on your local machine
go mod edit  -replace github.com/projectdiscovery/uncover=/Users/tarun/Codebase2/uncover

step 3) build nuclei and run

$ ./nuclei

                     __     _
   ____  __  _______/ /__  (_)
  / __ \/ / / / ___/ / _ \/ /
 / / / / /_/ / /__/ /  __/ /
/_/ /_/\__,_/\___/_/\___/_/   v2.9.5

		projectdiscovery.io

[INF] Current nuclei version: v2.9.5 (latest)
[INF] Current nuclei-templates version: v9.5.0 (latest)
[INF] New templates added in latest release: 62
[INF] Templates loaded for current scan: 5961
[INF] No results found. Better luck next time!

Copy link
Member

@dogancanbakir dogancanbakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsandeep ehsandeep merged commit bfd7e02 into dev Jun 1, 2023
@ehsandeep ehsandeep deleted the issue-229-provider-file-check branch June 1, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add file check before reading provider config [ERR] failed to load provider keys got yaml: unmarshal errors:

3 participants