Skip to content

Fixing provider keys load#201

Merged
ehsandeep merged 5 commits intodevfrom
issue-144-quake
Apr 21, 2023
Merged

Fixing provider keys load#201
ehsandeep merged 5 commits intodevfrom
issue-144-quake

Conversation

@Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Apr 20, 2023

Closes #144 and potentially other issues related to missing/mixed api keys

$ go run . -qk 'domain:\"google.com\"' -v -provider .\providers.yaml
...
quake] 113.108.239.253:443
[quake] 203.208.39.253:443
...

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Apr 20, 2023
@Mzack9999 Mzack9999 self-assigned this Apr 20, 2023
@Mzack9999 Mzack9999 linked an issue Apr 20, 2023 that may be closed by this pull request
@Mzack9999 Mzack9999 marked this pull request as draft April 20, 2023 16:41
@Mzack9999 Mzack9999 marked this pull request as ready for review April 20, 2023 17:21
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !

nice catch on env vars (seems like we totally missed that)

$  go run . -qk 'domain:\"google.com\"' -v 

  __  ______  _________ _   _____  _____
 / / / / __ \/ ___/ __ \ | / / _ \/ ___/
/ /_/ / / / / /__/ /_/ / |/ /  __/ /    
\__,_/_/ /_/\___/\____/|___/\___/_/

		projectdiscovery.io

[INF] Current uncover version v1.0.4-dev (dev)
[quake] 39.106.93.119:443
[quake] 43.154.172.34:80
[quake] 142.0.129.132:80
[quake] 142.0.129.129:80
[quake] 38.55.40.128:80
[quake] 164.88.252.192:80
[quake] 95.168.170.165:443
[quake] 142.0.129.129:80
[quake] 38.55.40.128:80

@tarunKoyalwar
Copy link
Member

New Changes

  • quake does not have a single json format and responds with entirely different format if there is a error . we include such data in err
$  ./uncover  -qk 'domain:"\google.com\"'   -v

  __  ______  _________ _   _____  _____
 / / / / __ \/ ___/ __ \ | / / _ \/ ___/
/ /_/ / / / / /__/ /_/ / |/ /  __/ /    
\__,_/_/ /_/\___/\____/|___/\___/_/

		projectdiscovery.io

[INF] Current uncover version v1.0.4-dev (dev)
[quake] [:RUNTIME] failed to decode quake response: map[code:q3015 data:map[] message:查询语句解析错误:domain:"\google.com\" meta:map[]] <- json: cannot unmarshal object into Go struct field Response.data of type []quake.responseData

@ehsandeep ehsandeep merged commit 45d5265 into dev Apr 21, 2023
@ehsandeep ehsandeep deleted the issue-144-quake branch April 21, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quake api is not working on windows

3 participants