-
Notifications
You must be signed in to change notification settings - Fork 257
Open
Labels
Type: BugInconsistencies or issues which will cause an issue or problem for users or implementors.Inconsistencies or issues which will cause an issue or problem for users or implementors.
Description
uncover version: 1.1.0
Current Behavior:
Our queries can contains double quotes to match a certain pattern. Unfortunnately, uncover is removing them, leading to false query beeing done.
The URL generated by Uncover is:
https://www.onyphe.io/api/v2/search/?q=issuer.commonname%3AQuasar+Server+CA&page=1&size=10
Expected Behavior:
The double quotes should be encoded, resulting to:
https://www.onyphe.io/api/v2/search/?q=issuer.commonname%3A%22Quasar+Server+CA%22&page=1&size=10
Steps To Reproduce:
1. Run './uncover -on issuer.commonname:"Quasar Server CA" -j'
2. There is no result
3. The query works on the Onyphe dashboard
Anything else:
The query is working on the Onyphe web dashboard

Notes:
This issue may also affect other search engines supported by Uncover if they rely on quoted queries for exact matching. It would be worth reviewing how double quotes are handled globally across all providers.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type: BugInconsistencies or issues which will cause an issue or problem for users or implementors.Inconsistencies or issues which will cause an issue or problem for users or implementors.