Skip to content

Add helper functions that returns callbacks of given tool (#79) #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 8 commits into from
Mar 3, 2023
Merged

Add helper functions that returns callbacks of given tool (#79) #80

ehsandeep merged 8 commits into from
Mar 3, 2023

Conversation

@RamanaReddy0M
Copy link
Contributor

@RamanaReddy0M RamanaReddy0M commented Feb 24, 2023

No description provided.

@tarunKoyalwar tarunKoyalwar linked an issue Feb 24, 2023 that may be closed by this pull request
Add Helper Function that returns callback of given tool #79
Closed
tarunKoyalwar
tarunKoyalwar requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting some changes !!

tarunKoyalwar
tarunKoyalwar requested changes Feb 27, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment •
edited by RamanaReddy0M
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implementation lgtm!
Suggesting some changes

  • create examples/main.go that uses these callbacks
  • add it to gh build workflow

Ref:https://github.com/projectdiscovery/tlsx

@RamanaReddy0M
- Create example for callback functions
e58a2bc 
- Add example to gh workflow
tarunKoyalwar
tarunKoyalwar approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@tarunKoyalwar tarunKoyalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!
this helper function and goflags callbackvar will be used in following way across all tools

pdtm/examples/main.go

Lines 16 to 32 in 87dc669

flagSet := goflags.NewFlagSet()
toolName := "nuclei"
flagSet.CreateGroup("update", "Update",
flagSet.CallbackVarP(utils.GetUpdaterCallback(toolName), "update", "up", fmt.Sprintf("update %v to the latest released version", toolName)),
flagSet.BoolVarP(&options.DisableUpdateCheck, "disable-update-check", "duc", false, "disable automatic update check"),
)
if err := flagSet.Parse(); err != nil {
panic(err)
}
if !options.DisableUpdateCheck {
msg := utils.GetVersionCheckCallback(toolName)()
fmt.Println(msg)
}
}

@tarunKoyalwar tarunKoyalwar removed the request for review from ShubhamRasal March 2, 2023 06:49
@tarunKoyalwar tarunKoyalwar requested review from ehsandeep and removed request for tarunKoyalwar March 3, 2023 06:54
@ehsandeep ehsandeep merged commit c3263fc into dev Mar 3, 2023
@ehsandeep ehsandeep deleted the issuse-79-add-callback-helpers branch March 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@RamanaReddy0M RamanaReddy0M

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Helper Function that returns callback of given tool

5 participants

@RamanaReddy0M @ehsandeep @Mzack9999 @tarunKoyalwar