Skip to content

Using repository name instead of binary name #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 1 commit into from
Jul 14, 2023
Merged

Using repository name instead of binary name #176

ehsandeep merged 1 commit into from
Jul 14, 2023

Conversation

@Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Jul 12, 2023 •
edited
Loading

Description

This PR replaces the binary tool name with the repository name, as GitHub allows to retrieve assets by repository name. Additionally, the binary name might not match the repository name (for example, interactsh has two binaries in the same repository with different names => reason why GH was returning 404).

$ go run . -u interactsh-server

                ____          
     ____  ____/ / /_____ ___ 
    / __ \/ __  / __/ __ __  \
   / /_/ / /_/ / /_/ / / / / /
  / .___/\__,_/\__/_/ /_/ /_/ 
 /_/                         

                projectdiscovery.io

[INF] Current pdtm version v0.0.7 (latest)
[INF] Run `source ~/.bashrc` to add /Users/marcornvh/.pdtm/go/bin to $PATH 
[INF] updating interactsh-server...

                                                                              
  ## What's Changed                                                           
                                                                              
  ### 🐞 Bugs                                                                 
                                                                              
  • Fixed issue of random failure to obtain public ip + fallback to outbound  
  ip on fail by @Ice3man543 in                                                
  https://github.com/projectdiscovery/interactsh/pull/599                     
                                                                              
  ### 🎉 Features                                                             
                                                                              
  • Export generated payload URLs to file by @dogancanbakir in                
  https://github.com/projectdiscovery/interactsh/pull/569                     
                                                                              
  ## New Contributors                                                         
                                                                              
  • @dogancanbakir made their first contribution in                           
  https://github.com/projectdiscovery/interactsh/pull/569                     
                                                                              
  Full Changelog:                                                             
  https://github.com/projectdiscovery/interactsh/compare/v1.1.4...v1.1.5      


[INF] updated interactsh-server to 1.1.5 (latest)

Closes #169

@Mzack9999 Mzack9999 added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 12, 2023
@Mzack9999 Mzack9999 self-assigned this Jul 12, 2023
@Mzack9999 Mzack9999 linked an issue Jul 12, 2023 that may be closed by this pull request
error msg even after successful update #169
Closed
@Mzack9999 Mzack9999 marked this pull request as ready for review July 12, 2023 23:10
@Mzack9999 Mzack9999 requested a review from tarunKoyalwar July 14, 2023 11:58
@Mzack9999 Mzack9999 requested a review from ehsandeep July 14, 2023 12:08
@ehsandeep ehsandeep merged commit 85caf59 into dev Jul 14, 2023
@ehsandeep ehsandeep deleted the bugfix-169-ua branch July 14, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@tarunKoyalwar tarunKoyalwar tarunKoyalwar approved these changes

Assignees

@Mzack9999 Mzack9999

Labels

Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error msg even after successful update

4 participants

@Mzack9999 @ehsandeep @tarunKoyalwar