Skip to content

replace underscore with escaped underscore #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 1 commit into from
Jul 8, 2023
Merged

replace underscore with escaped underscore #270

ehsandeep merged 1 commit into from
Jul 8, 2023

Conversation

@bugrakocabay
Copy link
Contributor

@bugrakocabay bugrakocabay commented Jun 10, 2023

As stated in this issue #239, when sending a message that has a "_" character in telegram gives an error. This is actually caused by parsing the message as markdown.

Issue has been solved by replacing all occurrences of underscore in string with escaped underscore.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bugrakocabay
Copy link
Contributor Author

bugrakocabay commented Jul 8, 2023

@ehsandeep review please

@ehsandeep ehsandeep linked an issue Jul 8, 2023 that may be closed by this pull request
Missing notifications for telegram #239
Closed
@ehsandeep ehsandeep added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jul 8, 2023
ehsandeep
ehsandeep approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@ehsandeep ehsandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bugrakocabay, just wanted to say thanks for fixing that bug! Sorry it took me a while to review it. Appreciate your help!

@ehsandeep ehsandeep merged commit 0e2f527 into projectdiscovery:dev Jul 8, 2023
@timsutton timsutton mentioned this pull request Feb 10, 2024
Merged
@moein9
Copy link

moein9 commented Feb 18, 2024

asterisk also should be escaped otherwise it gets an error.

echo "*.eg.com"|notify

Bad Request: can't parse entities: Can't find end of the entity starting at byte offset 0

@fopina-ci fopina-ci mentioned this pull request Jun 30, 2024
Merged
@fopina
Copy link

fopina commented Jul 17, 2024

How is this PR even merged?

If you escape all _ (and all * as someone else asked) then you're preventing markdown characters to be used.

If you don't want markdown, then don't use markdown parse mode in the provider configuration to start with....!

This broke usage for those actually formatting for markdown...

@fopina fopina mentioned this pull request Jul 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

No one assigned

Labels

Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing notifications for telegram

4 participants

@bugrakocabay @moein9 @fopina @ehsandeep