Added dataJsonString to custom provider format handler. #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change example `notify -version` to `notify -verbose`. It's a small typo.
Fix a typo mistake in README.md
Added dataJsonString to custom format - it treats data ans json string that needs to be escaped.
Added support for sprig and json input when using custom_sprig option
Better error info
Added an examples for dataJsonString and custom_sprig
Member
tarunKoyalwar
left a comment
tarunKoyalwar
left a comment
There was a problem hiding this comment.
PR Summary
- adds
dataJsonFormatcustom format which marshals given msg to json and injects json string .example
custom:
- id: webhookJson
custom_webhook_url: http://host/api/webhook
custom_method: GET
custom_format: '{"text":{{dataJsonString}} }'
custom_headers:
Content-Type: application/json
X-Api-Key: XXXXX- adds support for sprig templating and helper functions (which is like nuclei dsl) Ref: http://masterminds.github.io/sprig/
- need confirmation on ^ from @Mzack9999 since this was closed earlier as not planned #114
- another thing to note is that all these changes are only done/implemented on
custom webhooks
|
Kudos, SonarCloud Quality Gate passed!
|
Mzack9999
approved these changes
Mar 11, 2023
Member
Mzack9999
left a comment
Mzack9999
left a comment
There was a problem hiding this comment.
lgtm - @tarunKoyalwar, the original issue was kept on hold as the change impacted the existing default behavior of the engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dataJsonString to custom format - it treats data ans json string that needs to be escaped.