Skip to content

Msg Format conflict fix #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 3 commits into from
Aug 10, 2022
Merged

Msg Format conflict fix #162

ehsandeep merged 3 commits into from
Aug 10, 2022

Conversation

@parrasajad
Copy link
Contributor

@parrasajad parrasajad commented Aug 8, 2022 •
edited
Loading

closes #161

@parrasajad parrasajad linked an issue Aug 8, 2022 that may be closed by this pull request
unable to use CliFormat to override ConfigFormat #161
Closed
@ehsandeep ehsandeep changed the title SelectFormat fix Msg Format conflict fix Aug 8, 2022
@ehsandeep ehsandeep requested a review from Mzack9999 August 8, 2022 15:49
Mzack9999
Mzack9999 requested changes Aug 9, 2022
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@parrasajad parrasajad requested a review from Mzack9999 August 10, 2022 06:01
@Mzack9999 Mzack9999 requested a review from ehsandeep August 10, 2022 06:47
@Mzack9999 Mzack9999 added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Aug 10, 2022
@ehsandeep ehsandeep merged commit 3597ad1 into dev Aug 10, 2022
@ehsandeep ehsandeep deleted the format-fix branch August 10, 2022 16:20
@ehsandeep ehsandeep removed the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Aug 10, 2022
@ehsandeep ehsandeep mentioned this pull request Aug 10, 2022
Closed
forgedhallpass pushed a commit that referenced this pull request Sep 23, 2022
@parrasajad @forgedhallpass
Msg Format conflict fix (#162)
72ba008 
* fix SelectFormat

* use sliceutil

* remove debug instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@parrasajad parrasajad

Labels

Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unable to use CliFormat to override ConfigFormat

4 participants

@parrasajad @ehsandeep @Mzack9999