Skip to content

introduced go.uber.org/ratelimit for rate-limit #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ehsandeep merged 1 commit into from
Jun 11, 2022
Merged

introduced go.uber.org/ratelimit for rate-limit #147

ehsandeep merged 1 commit into from
Jun 11, 2022

Conversation

@LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented Jun 10, 2022 •
edited
Loading

This PR introduces go.uber.org/ratelimit for rate-limit.
Test: yes | head -n10 | time ./notify -rate-limit=10

@LuitelSamikshya LuitelSamikshya self-assigned this Jun 10, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@LuitelSamikshya LuitelSamikshya linked an issue Jun 10, 2022 that may be closed by this pull request
-rate-limit=n allows an initial burst of n requests then slows to 1/sec #139
Closed
@LuitelSamikshya LuitelSamikshya added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jun 10, 2022
@LuitelSamikshya LuitelSamikshya added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Jun 10, 2022
@ehsandeep ehsandeep merged commit 0f09512 into dev Jun 11, 2022
@ehsandeep ehsandeep deleted the issue-139-rate-limit branch June 11, 2022 08:39
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels

Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

-rate-limit=n allows an initial burst of n requests then slows to 1/sec

4 participants

@LuitelSamikshya @ehsandeep @Mzack9999