Add ability to comment input and strip before parsing#472
Merged
Mzack9999 merged 6 commits intoprojectdiscovery:mainfrom Sep 6, 2024
Merged
Add ability to comment input and strip before parsing#472Mzack9999 merged 6 commits intoprojectdiscovery:mainfrom
Mzack9999 merged 6 commits intoprojectdiscovery:mainfrom
Conversation
Strip # comments and whitespace from input file if line has # example 127.0.0.1 #sample comment
Added test for input with comment. Fixed typos
When fixing typos forgot integration test for comments.
fixed minor spacing typo
|
Great, thank you for your contribution @ddfault ! |
Contributor
Author
|
Not a problem. Is this good to go or do you need more from me on this pull request? I believe the errors in Build tests are unrelated to my code changes. |
Mzack9999
approved these changes
Sep 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! Fixed some typos. I am using source files where I want to comment IP/CIDR so I know what or where something came from. Added a integration test with some comments. Example input such as:
commentexample.txt
Usage: mapcidr.exe -cl commentexample.txt -a
Or
127.0.0.1 #comment 1,127.0.0.2 # another comment, 127.0.0.3#comment with no spaceUsage: mapcidr.exe -cl "127.0.0.1 #comment 1,127.0.0.2 # another comment, 127.0.0.3#comment with no space"