Merged
Conversation
WalkthroughAdds CLI flags to list public Result fields and to exclude specified fields from outputs; when requested, prints Result field names and exits. During enumeration output handling, results are filtered to remove any fields listed in the exclude flag before further processing. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant CLI
participant Parse as ParseOptions
participant Runner
participant OutG as Output Goroutine
participant Structs as structs
User->>CLI: run with flags
CLI->>Parse: ParseOptions()
alt --list-output-fields set
Parse->>Structs: GetStructFields(Result)
Structs-->>Parse: field names / error
Parse-->>User: print fields / exit(0)
else normal flow
Parse-->>Runner: options
Runner->>OutG: emit resp
alt exclude flags non-empty
OutG->>Structs: FilterStruct(resp, include=nil, exclude=flags)
Structs-->>OutG: filtered resp / error
OutG->>OutG: replace resp with filtered resp
else no excludes
OutG->>OutG: keep original resp
end
OutG-->>Runner: continue OnResult/JSON/CSV handling
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
runner/options.go(4 hunks)runner/runner.go(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: release-test
- GitHub Check: Functional Test (windows-latest)
- GitHub Check: Functional Test (macOS-latest)
- GitHub Check: Functional Test (ubuntu-latest)
- GitHub Check: Analyze (go)
🔇 Additional comments (3)
runner/options.go (2)
34-34: LGTM: Import addition for struct utilitiesThe import is correctly added and necessary for the new dynamic filtering functionality.
552-561: LGTM: Well-implemented field listing functionalityThe implementation correctly:
- Checks the flag condition
- Uses appropriate error handling with fatal exit
- Provides clean output format
- Follows the early exit pattern for utility flags
runner/runner.go (1)
44-44: Good addition of the required import.The new import for the structs utility package is correctly positioned and necessary for the filtering functionality.
Mzack9999
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2103
Summary by CodeRabbit