fix(utils): return immediately on first successful dial#512
Merged
dwisiswant0 merged 1 commit intomainfrom Dec 8, 2025
Merged
Conversation
`(*DialWrap).dialAllParallel()` previously waited for all goroutines to complete before returning, even after a successful conn was established. This caused 10+ second delays when dialing hostnames that resolve to multiple IPs (e.g., localhost => 127.0.0.1 + ::1) where some IPs have no listener. Use a results channel with ctx cancellation to return the first successful conn immediately. Remaining dial attempts are cancelled via ctx, and a background goroutine drains any in-flight results to prevent leaks. Found via block profile analysis showing `sync.WaitGroup.Wait` blocking for the full dial timeout duration. Fixes #511. Signed-off-by: Dwi Siswanto <[email protected]>
Mzack9999
approved these changes
Dec 8, 2025
dwisiswant0
deleted the
dwisiswant0/fix/utils/return-immediately-on-first-successful-dial
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: projectdiscovery/nuclei#6631
fix(utils): return immediately on first successful dial
(*DialWrap).dialAllParallel()previously waitedfor all goroutines to complete before returning,
even after a successful conn was established. This
caused 10+ second delays when dialing hostnames
that resolve to multiple IPs (e.g., localhost =>
127.0.0.1 + ::1) where some IPs have no listener.
Use a results channel with ctx cancellation to
return the first successful conn immediately.
Remaining dial attempts are cancelled via ctx, and
a background goroutine drains any in-flight
results to prevent leaks.
Found via block profile analysis showing
sync.WaitGroup.Waitblocking for the full dialtimeout duration.
Fixes #511.