Conversation
Mzack9999
previously requested changes
Oct 20, 2022
Member
Mzack9999
left a comment
Mzack9999
left a comment
There was a problem hiding this comment.
Please try to refactor the SetProxy method by reducing complexity and increase code readability, for example:
- Move URL checking and setproxy for each item into a proper routine
- Move the file process utility into a subroutine
- Reduce
ifnesting by preferringerr != nilchecks and early return
Closed
Mzack9999
added
the
Type: Enhancement
Mzack9999
approved these changes
Oct 23, 2022
ehsandeep
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples
socks5:
http:
input file support: