GRPCRoute: add unit test cases #5104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for 1.TestGetListenersForRotueParentRef
2.TestDAGInsertGatewayAPI
Updates projectcontour#4820
Signed-off-by: Yu Ying <[email protected]>
Updates projectcontour#4820 Signed-off-by: Yu Ying <[email protected]>
vmw-yingy
requested review from
stevesloka and
tsaarni
and removed request for
a team
Member
|
Looks like two small lint issues to fix before CI can run (see the comments in the "Files changed" tab) |
Updates projectcontour#4820 Signed-off-by: Yu Ying <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-grpcroute #5104 +/- ##
=================================================
+ Coverage 77.05% 77.44% +0.38%
=================================================
Files 140 140
Lines 17146 17161 +15
=================================================
+ Hits 13212 13290 +78
+ Misses 3665 3602 -63
Partials 269 269
|
Member
|
These look good, thanks @vmw-yingy. I'll merge this, then push a merge of the |
skriss
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding GRPCRoute test cases for TestGetListenersForRotueParentRef and TestDAGInsertGatewayAPI
Fix mirror service default protocol type