Gateway API: implement ReferencePolicy #4138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skriss
requested review from
stevesloka and
sunjayBhatia
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #4138 +/- ##
==========================================
+ Coverage 72.91% 72.98% +0.06%
==========================================
Files 115 115
Lines 10053 10097 +44
==========================================
+ Hits 7330 7369 +39
- Misses 2567 2572 +5
Partials 156 156
|
skriss
added
the
release-note/minor
skriss
force-pushed
the
gateway-reference-policy
branch
from
f1d5629 to
5da31d1
Compare
youngnick
approved these changes
Oct 27, 2021
Member
youngnick
left a comment
youngnick
left a comment
There was a problem hiding this comment.
This LGTM, it also looks like we should be able to expand it out easily to cover cross-namespace Secrets at some point (which is planned, but not in the spec yet).
sunjayBhatia
reviewed
Nov 1, 2021
sunjayBhatia
approved these changes
Nov 1, 2021
skriss
force-pushed
the
gateway-reference-policy
branch
2 times, most recently
from
1e387db to
ea9bac5
Compare
Implements ReferencePolicy, which enables certain cross-namespace references to be allowed. This currently applies only to Route->Service refs. Closes projectcontour#4118. Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
gateway-reference-policy
branch
from
ea9bac5 to
b5b358b
Compare
skriss
added a commit
to skriss/contour-operator
that referenced
this pull request
Nov 1, 2021
Updates operator per Contour changes: projectcontour/contour#4141 projectcontour/contour#4138 projectcontour/contour#4145 Signed-off-by: Steve Kriss <[email protected]>
stevesloka
pushed a commit
to projectcontour/contour-operator
that referenced
this pull request
Nov 2, 2021
Updates operator per Contour changes: projectcontour/contour#4141 projectcontour/contour#4138 projectcontour/contour#4145 Signed-off-by: Steve Kriss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements ReferencePolicy, which enables certain
cross-namespace references to be allowed. This
currently applies only to Route->Service refs.
Closes #4118.
Signed-off-by: Steve Kriss [email protected]