internal/envoy/v3: Strip possible port from :authority header #3422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we don't have to have routes match on a wildcard suffix. Makes internal Contour logic simpler as we don't have to think about a possible port in route matches any longer and would make adding support for wildcard domains a little easier. Downsides: - More Lua - Strips port from header that some application may care about? Could also apply this change *only* for wildcard routes but it seemed good to be consistent. Signed-off-by: Sunjay Bhatia <[email protected]>
sunjayBhatia
requested review from
skriss and
youngnick
and removed request for
a team
Member
Author
|
Context around this PR is here: #3381 (comment) |
Codecov Report
@@ Coverage Diff @@
## main #3422 +/- ##
==========================================
- Coverage 75.07% 75.04% -0.04%
==========================================
Files 98 98
Lines 6584 6584
==========================================
- Hits 4943 4941 -2
- Misses 1532 1533 +1
- Partials 109 110 +1
|
Member
Author
|
Realized this isn’t complete, the Lua filter is only added for TLS routes |
Member
Author
|
Closing as this can be replaced by using this feature of the HTTP Connection Manager: https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto.html#envoy-v3-api-field-extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-strip-any-host-port |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we don't have to have routes match on a wildcard suffix.
Makes internal Contour logic simpler as we don't have to think about
a possible port in route matches any longer and would make adding
support for wildcard domains a little easier.
Downsides:
Could also apply this change only for wildcard routes but it seemed
good to be consistent.