build: make docker-clone needs CLONE_D #745
Conversation
mikemccracken
requested review from
hallyn,
raharper,
rchamarthy,
rchincha,
smoser and
tych0
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
==========================================
+ Coverage 51.67% 60.92% +9.25%
==========================================
Files 59 57 -2
Lines 6491 5049 -1442
==========================================
- Hits 3354 3076 -278
+ Misses 2489 1323 -1166
- Partials 648 650 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you confirm this is needed? The github workflow uses things like this; Why do those work without your change? |
Those work because the value they send for CLONE_D happens to be the same as the hardcoded value in the Makefile:
|
raharper
left a comment
raharper
left a comment
There was a problem hiding this comment.
Thanks for cleanup here.
hacking.md told lies about setting CLONE_D and how to use it. This actually adds the variable. Signed-off-by: Michael McCracken <[email protected]>
mikemccracken
force-pushed
the
2025.12.03/main/missing-clone-d
branch
from
4b8ec1f to
c3bc3fb
Compare
2 participants
hacking.md told lies about setting CLONE_D and how to use it.
This actually adds the variable.
What type of PR is this?
documentation
What does this PR do / Why do we need it:
It fixes lies / We shouldn't lie
If an issue # is not available please add repro steps and logs showing the issue:
make docker-clonewith CLONE_DBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.