Fix/arm64 stacker build #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
===========================================
- Coverage 60.43% 10.33% -50.11%
===========================================
Files 59 59
Lines 6491 6491
===========================================
- Hits 3923 671 -3252
- Misses 1920 5710 +3790
+ Partials 648 110 -538 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hallyn
approved these changes
Oct 18, 2025
raharper
force-pushed
the
fix/arm64-stacker-build
branch
from
12f5e11 to
e8a3e17
Compare
- Update install deps script to add some additional packages that
may not be installed in the arm64 image
- Remove hard-coded amd64/x86_64 binaries and strings
- use GOARCH to build suffix for binary downloads
- docker convert should use runtime.GOARCH
set a default value for PRIVILEDGE_LEVEL for non github runners
- add additional packages which are dependencies found during
make check/test
- invoke make check with the same STACKER_DOCKER_BASE to ensure
we don't fetch non-GOARCH images
- fix possible issue with quoted parameter during docker-clock
- Adjust github build workflow for publishing multi-arch
- Add in maxtrix.platform strategy for 24.04 and 24.04-arm
- Add a make publish-stacker-bin target which uses GOOS and GOARCH
to name the stacker binary
- Add build step to copy stacker to final name for publish
- Adjust build job name to use defined matrix variable
- Use matrix.platform and remove / from value
Signed-off-by: Ryan Harper <[email protected]>
raharper
force-pushed
the
fix/arm64-stacker-build
branch
from
8ba8092 to
f13b6a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
Building the stacker arm64 binary on arm64 runner has been failing
What does this PR do / Why do we need it:
Adjust where we get build and test images (ECR) which have multi-arch images
If an issue # is not available please add repro steps and logs showing the issue:
#735
Testing done on this change:
Local build on arm64 VM with the PR produces a functional static stacker go binary.
Automation added to e2e:
none
Will this break upgrades or downgrades?
no
Does this PR introduce any user-facing change?:
no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.