ci: update 3rd party sync for multi-arch #736
Conversation
rchincha
requested review from
Copilot and
rchamarthy
and removed request for
hallyn and
smoser
There was a problem hiding this comment.
Pull Request Overview
Updates GitHub workflow to support multi-architecture builds for 3rd party image synchronization by adding matrix strategy for amd64 and arm64 architectures.
- Adds matrix strategy to run jobs for both amd64 and arm64 architectures
- Updates docker commands to pull platform-specific images and tag them with architecture suffix
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| docker tag public.ecr.aws/docker/library/$n "$dest" | ||
| docker push $dest | ||
| docker pull --platform linux/${{ matrix.arch }} public.ecr.aws/docker/library/$n | ||
| docker tag public.ecr.aws/docker/library/$n "$dest"-${{ matrix.arch }} |
There was a problem hiding this comment.
The docker tag command uses the original image name without platform specification, but the pulled image is platform-specific. This could cause tagging issues. Consider using a platform-specific image reference or ensure the local image name matches what was pulled.
| docker tag public.ecr.aws/docker/library/$n "$dest"-${{ matrix.arch }} | |
| image_id=$(docker images --format "{{.ID}}" public.ecr.aws/docker/library/$n | head -n 1) | |
| docker tag $image_id "$dest"-${{ matrix.arch }} |
There was a problem hiding this comment.
Do we need to tag the images with the -arch ? I think the image libraries will pull the right arch if present in the repository, right?
There was a problem hiding this comment.
This way we don't need to change the build.yaml
There was a problem hiding this comment.
Well, we are not pushing a full image index but individual manifests.
Let me see if we can replace this with skopeo instead
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #736 +/- ##
=======================================
Coverage 60.43% 60.43%
=======================================
Files 59 59
Lines 6491 6491
=======================================
Hits 3923 3923
Misses 1920 1920
Partials 648 648 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Ramkumar Chinchani <[email protected]>
2 participants
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.