Conversation
hectcastro
approved these changes
Jan 28, 2019
Contributor
hectcastro
left a comment
hectcastro
left a comment
There was a problem hiding this comment.
I think it would be good to include a little detail about why we weren't able to work with pip 19 in the commit message. We don't know all of the details, but some explanation would be helpful for the person (possibly us) down the road who sees the pip version constraint and wants to update it.
When pip 19.0 was released, builds started failing with messages similar to Cannot uninstall 'requests'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall. When we stopped installing the python-requests-whl package, this error would move to another package, like urllib3. In the end, it seemed that pinning the pip version to 18.1 prevented these errors from happening.
rbreslow
force-pushed
the
feature/jrb/fix-ami-builds
branch
from
ffed246 to
2a47bfd
Compare
rajadain
added a commit
to WikiWatershed/model-my-watershed
that referenced
this pull request
Jan 29, 2019
As of pip 19.0, it started printing warnings for Python 2.7, which are treated as errors by Jenkins. I looked briefly in to ignoring or silencing those warnings (see pypa/pip#6147 (comment)), but couldn't configure Jenkins correctly. Thus, I'm going with the downgrade, as was done for #bees in project-icp/bee-pollinator-app#447.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Between Jenkins builds #120 and #121,
pip 19.0was released (https://pypi.org/project/pip/#history).We weren't pinning to a specific version of
pipin the Packer shell provisioner, so builds started usingpip 19.0, and builds started failing.Fixes #441
Testing Instructions
See successful CI build: http://civicci01.internal.azavea.com/job/bee-pollinator-app-and-worker/129/