Fix implicit shadowing by an auto-generated "pointer-name" for a struct #168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An old, ugly, unused feature of 3D to auto-generate a name for a pointer to a struct causes unexpected shadowing.
In particular, say you have:
Then, 3D would also implicit bind the name PT to the type T*, this name can shadow the use of a
PTalready defined, leading to much confusion.This PR fixes it by no longer auto-generating such a name, which is much more sane.