Removing need for FSTAR_HOME #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, define FSTAR_EXE ?= fstar.exe, and pass --fstar to 3d and -fstar to krml to make sure we respect it.
Member
Author
|
Updated with the A run of the Github actions CI going on here https://github.com/mtzguido/everparse/actions/runs/12719269191. |
…fore building karamel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(from commit messages:)
F* discovery: use FSTAR_EXE ?= fstar.exe
Note: 3d itself also inspects this variable (it was inspecting
FSTAR_HOME before). It may be easier to remove this behavior and add a
flag, so the fstar used is explicit in the Makefiles.
Remove most uses of FSTAR_HOME
A few remain in package.sh, but there it does in fact need a repo
(afaict) so I kept it. There is also the warning in everest.sh, but I'm
not sure why it's checking for FSTAR_HOME in the first place.
Most of this is untested... it does build, but I didn't run the workflows.
Note: For this PR to work with FSTAR_EXE alone (and no fstar.exe in the PATH), krml must also respect FSTAR_EXE (FStarLang/karamel#512). Or we would need a krml option to choose an fstar bypassing the detection.