Explicitly add lmorandomizer bin crate to cargo for Tauri#25
Merged
progre merged 1 commit intoprogre:mainfrom Jul 27, 2024
Merged
Explicitly add lmorandomizer bin crate to cargo for Tauri#25progre merged 1 commit intoprogre:mainfrom
progre merged 1 commit intoprogre:mainfrom
Conversation
Owner
|
Thank you for confirming this! I prefer to define the main module before all the bins, so it would be helpful if you could change it that way. By the way, is it true that it works on mac? This was the default behavior of the build tool, so I left it as is, but I figured no one would use it on a mac and was going to remove it. |
Contributor
Author
|
I'll get this updated momentarily, I think I'm interpreting what you mean correctly. The randomizer does indeed work on Mac (arm). One of the big benefits of Rust. Ironically, I don't play La Mulana on my mac, but since it's my primary development machine, I ran into this. |
Reverse ordering.
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The introduction of
lmocodecbroke application bundling via Tauri.On MacOS, we can see this due to the generated plist:
This appears to be undocumented(?) behavior in Tauri, but by adding a binary to our cargo.toml matching our tauri application name, it appears to successfully pick up both binaries, and correctly link the bundle.
Prior to this change, the generated .app bundle on MacOS only contains the
lmocodecbinary, and I have a similar report from a friend on Windows.