Update reference for v11, fix locked version on p5 update #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Looks like it's a cdnjs issue: cdnjs/cdnjs#14261 |
Collaborator
Author
|
If we want to use another CDN in the mean time, https://cdn.jsdelivr.net/npm/[email protected]/lib/p5.min.js is working. Edit: just put up #579 in case we want to release using an alternative CDN |
Merged
Collaborator
|
Thanks @davepagurek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: do not merge this until https://cdnjs.cloudflare.com/ajax/libs/p5.js/1.11.0/p5.min.js is live! It updates src/globals/p5-version.ts, which will cause the reference to use the new built library.
Previously, I had locked the version number in the reference building script to v1.10.0 so we could rebuild it whenever without getting newer, unreleased contents from main. Now that we've done a v1.11.0 release, I realize we already have a p5 version constant in our codebase, so when we updated, the reference was still being built from the previous release.
I've updated the reference builder script to now use the p5 version that is outputted by
npm run build:p5-version, and I've rebuilt the reference with the new content.