Skip to content

Fix JSDoc return type for p5.Vector.cross #8336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davepagurek merged 1 commit into from
Dec 18, 2025
Merged

Fix JSDoc return type for p5.Vector.cross #8336

davepagurek merged 1 commit into from
Dec 18, 2025

Conversation

@Geethegreat
Copy link
Contributor

@Geethegreat Geethegreat commented Dec 17, 2025 •
edited
Loading

Resolves #8335

Changes:

Updated the JSDoc return type for p5.Vector.cross(v1, v2) to reflect its actual runtime behavior (returns p5.Vector).

PR Checklist

@welcome
Copy link

welcome bot commented Dec 17, 2025

🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors!
🤔 Please ensure that your PR links to an issue, which has been approved for work by a maintainer; otherwise, there might already be someone working on it, or still ongoing discussion about implementation. You are welcome to join the discussion in an Issue if you're not sure!
🌸 Once your PR is merged, be sure to add yourself to the list of contributors on the readme page !

Thank You!

davepagurek
davepagurek approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@davepagurek davepagurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have you checked to see if this is an issue in p5 2.0 too? If so, are you interested in making a PR into the dev-2.0 branch with a similar update?

@Geethegreat
Copy link
Contributor Author

Geethegreat commented Dec 18, 2025

Yes, I checked and the same issue exists in the dev-2.0 branch as well.
I’d be happy to make a similar PR targeting dev-2.0.

@davepagurek davepagurek merged commit fca49c5 into processing:main Dec 18, 2025
2 checks passed
@davepagurek
Copy link
Contributor

davepagurek commented Dec 18, 2025

@all-contributors please add @Geethegreat for code

@allcontributors allcontributors bot mentioned this pull request Dec 18, 2025
Merged
@allcontributors
Copy link
Contributor

allcontributors bot commented Dec 18, 2025

@davepagurek

I've put up a pull request to add @Geethegreat! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davepagurek davepagurek davepagurek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[p5.js 2.0 Bug Report]: types say p5.Vector.cross(v1,v2) returns number not Vector (jsdoc+types only)

2 participants

@Geethegreat @davepagurek