Hi, thanks for making this PR! We can avoid explicitly checking the type of the renderer here by moving this code into the 3D renderer class instead. Because it calls _renderer.background(...), it will call the background method on whatever the active renderer is, so we can add specific code for WebGL in the WebGL renderer, and it already knows it's WebGL at that point.

In this case, I think that would mean moving your code into here:

The one difference is that in the renderer, this is the renderer and not the p5 instance, so what is currently a call to this.push() for example would turn into this._pInst.push().

I believe this problem also exists in p5 2.0, whose code lives in the dev-2.0 branch. Would you be interested in making similar changes there? Likely the change would go in the Renderer3D file.

@all-contributors please add @reshma045 for code

@davepagurek

@reshma045 already contributed before to code

I believe this problem also exists in p5 2.0, whose code lives in the dev-2.0 branch. Would you be interested in making similar changes there? Likely the change would go in the Renderer3D file.

Thanks @davepagurek. Yes, happy to take a look at the dev-2.0 branch and make a similar fix there. I’ll implement it and open a follow up PR.