Skip to content

3 unit tests associated with tint sometimes fail when running in GH Action #5772

@stalgiag

Description

@stalgiag

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)

p5.js version

main

Web browser and version

N/A

Operating System

N/A

Steps to reproduce this

Open a pull request and look at the tests. If there isn't a failure re-run them or look at the time readouts next to the 'displaying images' tests.

I noticed this after I had to restart unit tests on two PRs included #5508 where the failed tests created some confusion.

Every time the GH actions run there is a chance that the unit tests in the 'displaying images' suite in images/loading.js will fail due to timeout (max 2000ms). The inconsistent behavior is likely due to the available resources on the virtual machine used to run the GitHub action.

These tests were added in #5471 . It is likely that these unit tests are a bit too resource-intensive for reliable testing on a VM. One possible fix would be reducing the size of the test image.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions