This repository was archived by the owner on Feb 28, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 28, 2021. It is now read-only.
grunt curl 's colorNamer.js has lint errors #97
Description
Nature of issue?
- Found a bug
- Existing feature enhancement
- New feature request
Details about the bug:
- Web browser and version:
- Operating System:
- Steps to reproduce this:
Following this step in the readme generates a new colorNamer.js with indents that eslint doesn't like.
run grunt curl to get the latest versions of the CDN libraries
Activity
spiray commentedon Aug 9, 2018
@mithru I am not seeing the same issue. Maybe it is your text editor settings? Either way, does running
eslint src/ --fixwork for you? Do you think i should add--fixin to the build script?lm-n commentedon Aug 9, 2018
I can fix in the color library.
mithru commentedon Aug 22, 2018
Tried
eslint src/ --fixon a borrowed machine and this happens (I see the same lint errors in colorNamer.js - I was using vim in both scenarios which defaults to 4-spaced tabs instead of a single space):Error: Cannot find module 'eslint-config-p5js'npm install --save-dev eslint-config-p5jsdoesn't seem to help either. I'm definitely missing something on both machines (Windows and Mac). Any ideas? Help, please.spiray commentedon Aug 22, 2018
@mithru I am not having this issue. Did you run
npm install? If so, can you try it in another editor to see if it is being caused by VIM's behavior?lm-n commentedon Sep 23, 2018
@mithru I've updated the colornamer could you try and let me know if there are no linting errors?
mithru commentedon Sep 27, 2018
@lm-n
The lint setup on p5 accessibility library still complains about spaces, but I think @spiray 's method of adding
--fixto the build script might be the way to handle this, since color namer doesn't necessarily have to abide by eslint-config-p5jsIn any case, here's what
npm run buildthrows at me.eslint src/ --fixfixes these indent issues.eslint-config-p5jsandeslintare installed globally on my machine though. I have not tried having both just local.mithru commentedon Sep 27, 2018
changing the colorNamer to es6 definitely helped.