All committers have signed the CLA.

♻️ PR Preview d153e3a has been successfully destroyed since this PR has been closed.

_{🤖 By surge-preview}

♻️ PR Preview d153e3a has been successfully destroyed since this PR has been closed.

_{🤖 By surge-preview}

@copilot new assignment
In the demo/tests, consider the 2 query parameters to ignore task and activity label bounds.
This is managed in dev/ts/shared/main.ts and the same place of ignoreBpmnColors for instance.
Extract the code managing the renderer options in a dedicated function as this is done for example in getFitOptionsFromParameters

@copilot new assignment
In the demo/tests, consider the 2 query parameters to ignore task and activity label bounds.
This is managed in dev/ts/shared/main.ts and the same place of ignoreBpmnColors f...

Done in commit 1b6c8b7. Added query parameters renderer.ignore.activity.label.bounds and renderer.ignore.task.label.bounds following the same pattern as ignoreBpmnColors and ignoreBpmnLabelStyles. Also extracted the renderer options management to a dedicated getRendererOptionsFromParameters() function as suggested.

@copilot the build is failing, fix the lint errors

@copilot the build is failing, fix the lint errors

Fixed in commit 892b38a. Removed trailing whitespace on lines 242 and 260 in dev/ts/shared/main.ts. Lint check now passes.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

This pull request introduces new renderer options that allow users to control whether BPMN label bounds are ignored for activities and tasks, improving customization of label rendering. The changes refactor renderer option handling, extend the RendererOptions type, update the style computation logic, and add comprehensive unit tests for the new behavior.

Renderer options and configuration

• Added two new options to RendererOptions: ignoreBpmnActivityLabelBounds and ignoreBpmnTaskLabelBounds, with clear documentation and precedence rules. These options allow users to ignore label bounds for all activities or just tasks, respectively. (src/component/options.ts [1] [2]
• Refactored renderer options initialization and query parameter mapping in main.ts, consolidating logic into a new getRendererOptionsFromParameters function and expanding support for the new options. (dev/ts/shared/main.ts [1] [2]

Style computation logic

• Updated StyleComputer to support the new renderer options, passing them to label style computation and ensuring correct option precedence. (src/component/mxgraph/renderer/StyleComputer.ts [1] [2]
• Modified computeLabelStyleValues and added shouldIgnoreBpmnLabelBounds to determine when label bounds should be ignored based on the element type and options. (src/component/mxgraph/renderer/StyleComputer.ts [1] [2]

Testing

• Added comprehensive unit tests to verify the behavior of the new options, including edge cases and precedence, ensuring that label bounds are correctly ignored or applied for activities, tasks, and other BPMN elements. (test/unit/component/mxgraph/renderer/StyleComputer.test.ts test/unit/component/mxgraph/renderer/StyleComputer.test.tsR600-R731)