Skip to content

chore: update syntax to import JSON modules#3279

Merged
tbouffard merged 3 commits into
masterfrom
chore/update_syntax_node_import_json
Feb 24, 2025
Merged

chore: update syntax to import JSON modules#3279
tbouffard merged 3 commits into
masterfrom
chore/update_syntax_node_import_json

Conversation

@tbouffard

@tbouffard tbouffard commented Feb 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Use the new syntax, the former one is deprecated and no longer works with Node 22.

Notes

Running with node v20.18.2 (this is the version currently used by GH Actions)

$ npm run generate-types:not-supported-ts-versions

> [email protected] generate-types:not-supported-ts-versions
> node scripts/generate-types-for-not-supported-ts-versions.mjs

(node:25841) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)

Running with node v20.18.3 (no more warnings)

npm run build-bundles

> [email protected] build-bundles
> rollup --strictDeprecations -c


src/bpmn-visualization.ts → dist/bpmn-visualization.js...
src/bpmn-visualization.ts:

@tbouffard
chore: update syntax to import JSON modules
1f8f86b 
Use the new syntax, the former one is deprecated and no longer works with Node 22.
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Feb 21, 2025
@tbouffard tbouffard marked this pull request as ready for review February 24, 2025 07:09
@tbouffard tbouffard requested a review from csouchet February 24, 2025 07:09
@sonarqubecloud

sonarqubecloud Bot commented Feb 24, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tbouffard tbouffard merged commit 62286ee into master Feb 24, 2025
@tbouffard tbouffard deleted the chore/update_syntax_node_import_json branch February 24, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@csouchet csouchet csouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tbouffard @csouchet