refactor: make class members readonly when possible#3227
Merged
tbouffard merged 2 commits intoDec 11, 2024
Conversation
Make the members readonly when they are not reassigned outside the constructor. This improves type safety and promotes immutability. This has been detected by SonarCloud. Use the related typescript-eslint rule to prevent this from appearing again. The eslint errors are auto-fixable, so this change will be transparent for developers.
|
♻️ PR Preview 4f51a03 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 4f51a03 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
csouchet
approved these changes
Dec 11, 2024
tbouffard
deleted the
chore/mark_class_members_as_readonly_when_possible
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the members readonly when they are not reassigned outside the constructor. This improves type safety and promotes immutability.
This has been detected by SonarCloud. Use the related typescript-eslint rule to prevent this from appearing again.
The eslint errors are auto-fixable, so this change will be transparent for developers.
Notes
See https://typescript-eslint.io/rules/prefer-readonly/